Update SDK initialization to use appLogoUrl instead of deprecated appLogo #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟡 Heimdall Review Status
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Updated the Base Account SDK initialization code in the documentation to use the correct property name appLogoUrl instead of the deprecated appLogo.
Notes to reviewers
This is a documentation-only change to align with the current SDK API
The old property name appLogo appears to be deprecated in favor of the more descriptive appLogoUrl
No functional changes to the codebase, only documentation updates
How has it been tested?
Verified against the latest SDK documentation that appLogoUrl is the correct property name
https://docs.base.org/base-account/reference/core/createBaseAccount
Confirmed that the example code compiles and runs correctly with the updated property name