Add basenames page to wagmi section #320
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟡 Heimdall Review Status
|
stevieraykatz
requested changes
Sep 11, 2025
|
|
||
| ## Wagmi | ||
|
|
||
| Before starting, make sure you have [set up Wagmi](/base-account/framework-integrations/wagmi/setup). |
|
|
||
| [Learn more about useEnsName →](https://wagmi.sh/react/api/hooks/useEnsName) | ||
|
|
||
| ## Viem |
There was a problem hiding this comment.
Include required version here too
Comment on lines
+23
to
+31
| import { useEnsName } from 'wagmi' | ||
| import { base } from 'wagmi/chains' | ||
|
|
||
| function App() { | ||
| const result = useEnsName({ | ||
| address: '0xd2135CfB216b74109775236E36d4b433F1DF507B', | ||
| chainId: base.id, | ||
| }) | ||
| } |
There was a problem hiding this comment.
have you run this to verify it works? I haven't tried the wagmi setup
| import { base } from 'viem/chains' | ||
|
|
||
| const client = createPublicClient({ | ||
| chain: base, |
There was a problem hiding this comment.
This HAS to be mainnet. All ENS requests start on mainnet. Under the hood, this makes sense since we don't know if a User on Base is using a domain that lives on Optimism. So the ENS infrastructure routes resolutions requests from mainnet to the correct chain.
|
Review Error for stevieraykatz @ 2025-09-11 17:11:25 UTC |
Co-authored-by: katzman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Basenames are ENSIP-19 compliant which makes the integration with wagmi/viem simple and straightforward. We added a guide to reflect this.