Modernise lua-archive #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,8 +38,12 @@ static int ar_version(lua_State *L) { | |||
| } | |||
|
|
|||
| ////////////////////////////////////////////////////////////////////// | |||
| #if !defined LUA_VERSION_NUM | |||
There was a problem hiding this comment.
Can this #if be refactored into a header (perhaps ar.h?) so we can avoid copying it into ar_entry.c?
From http://lua-users.org/wiki/CompatibilityWithLuaFive: luaL_reg (Lua 5.0) changed its name to luaL_Reg since Lua 5.1. Apply the recommended fix to support lua 5.1 and prior versions.
Use lua_getuservalue()/lua_setuservalue() instead of the removed lua_getfenv()/lua_setfenv().
Replace the deprecated functions with their libarchive 3.0 replacements as listed at: https://github.com/libarchive/libarchive/wiki/ManPageLibarchiveChanges3
"wrote" was checked against -1 but was never actually set.
When running the tests, libarchive says: InvalidFFlag: 'archive' is not a known fflag So remove that one flag from our tests.
|
Note that I had to disable the "__gc" functions for the code to work and the tests to pass on Lua 5.3. I don't think that the existing code should regress on 5.1 or older, but I'm still investigating the problems with newer Lua versions. |
|
It at least compiles and loads for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lua 5.2 and 5.3 support, as well as porting to libarchive 3.0.
Untested.