Implement async send. #27
Conversation
With flexible multi-threading support.
There was a problem hiding this comment.
I don't know what the "right" answer is to this problem, but my concern with the current solution is in regards to object lifetimes and the fact that we can now crash the process... and if someone uses this API thinking it is safe, they will request support.
Thank you for the contribution, but at this time, I'd only support the addition of the ev.ASYNC constant and async:send(loop) additions, until we can think about a better way to handle the sending/receiving of the async/loop handlers in a way that is safe.
| void *udata = lua_touserdata(L, lua_upvalueindex(1)); | ||
| struct async_serialized* data = (struct async_serialized*)udata; | ||
|
|
||
| ev_async_send(data->loop, data->async); |
There was a problem hiding this comment.
How can we ensure the lifetime of the data->async is still valid when this is called?
| luaL_error(L, "invalid data size"); | ||
|
|
||
| void* data = lua_newuserdata(L, sizeof(struct async_serialized)); | ||
| memcpy(data, str, sizeof(struct async_serialized)); |
There was a problem hiding this comment.
How can we ensure that the memory pointed to by the fields of the async_serialized structure are still valid?
I couldn't get the tests to work (wrote one anyway), but I did manual testing and integration into an existing project without issues.
(from #25)