Merging capnproto-java-rpc
#149
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correctly brand RpcClient don't run message loop inside promise imbue payload
Imbue readers and writers with capTables. Ensure caps are removed when pointers are zeroed out.
Patches to assist porting back to official release
Fix generic structs with non-generic interface as type parameter
* replace ACTION_TOKEN with GITHUB_TOKEN * try removing token
Co-authored-by: octeep <[email protected]>
Lists can have up to 29 bits of elements. We multiply that by a constant of 8 (Bytes per word), so basically any element size can cause on overflow.
* Remove unnecessary bitwise and in WirePointer * Remove always true condition in Serialize * Pre-size segment ArrayList in Serialize * Remove unused local var in Serialize * Remove unnecessary bit shift in PackedOutputStream#write * Make fields final in BuilderArena and Serialize * Make Iterator classes static in DataList and TextList * Pre-size ArrayList in ReaderArena constructor
sebastianbergt
commented
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found https://github.com/vaci/capnproto-java-rpc and thought it would be nice to bring it up to speed on all the changes in https://github.com/capnproto/capnproto-java 's master, since I need the rpc capability.
I ended up fixing all the merge conflicts and it seems working (judging from the tests).
Since I did this anyway, I wondered, if you might want it as a contribution.
If you want anything changed to qualify it for merging, let me know.
This PR is huge, I do understand if you want to turn it down.