[jobs] Handle ObjectDoesNotExist in recommendations #1006
+68
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running unify or merging individuals while recommendations are in progress, an individual may no longer exist or may have already been merged. Handle this scenario by checking whether the individual is missing before creating the recommendation. Signed-off-by: Jose Javier Merchante <[email protected]>
jjmerchante
force-pushed
the
fix-recommend-removed
branch
from
9300340 to
a2a7718
Compare
sduenas
reviewed
Sep 17, 2025
| continue | ||
| elif indiv_1 > indiv_2: | ||
| indiv_1, indiv_2 = indiv_2, indiv_1 | ||
|
|
||
| try: |
There was a problem hiding this comment.
Why is this not needed anymore?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running unify or merging individuals while recommendations are in progress, an individual may no longer exist or may have already been merged.
Handle this scenario by checking whether the individual is missing before creating the recommendation.