Add VPC Connectivity SASL Scram and IAM

[PlexusLoganPope]

what

• Added support for VPC connectivity client authentication using SASL/IAM and SASL/SCRAM.
• Updated resource configuration to include the necessary properties for enabling VPC connectivity client authentication IAM and SCRAM.
• Added variables to configure VPC connectivity client authentication IAM and SCRAM.
• Updated module documentation to include the new VPC connectivity client authentication configuration options.

why

• This module does not currently support configuration VPC connectivity for private link functionality.
• This enhancement provides ability to configure VPC connectivity and enables the usage of private link.

references

• AWS Access Across VPC Documentation --> https://docs.aws.amazon.com/msk/latest/developerguide/aws-access-mult-vpc.html

[mergify]

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

[RoseSecurity]

/terratest

[Benbentwo]

Similar to #136 my only fears are if the block does not work when no value is supplied.

We also need to get tests working.

[Benbentwo]

Suggested change

	vpc_connectivity {
	client_authentication {
	sasl {
	iam = var.vpc_connectivity_client_authentication_sasl_iam_enabled
	scram = var.vpc_connectivity_client_authentication_sasl_scram_enabled
	}
	}
	}
	dynamic "vpc_connectivity" {
	for_each = var.vpc_connectivity == null ? [] : [var.vpc_connectivity]
	content {
	client_authentication {
	dynamic "sasl" {
	for_each = (
	try(vpc_connectivity.value.sasl_iam_enabled, null) != null ||
	try(vpc_connectivity.value.sasl_scram_enabled, null) != null
	) ? [1] : []
	content {
	iam = try(vpc_connectivity.value.sasl_iam_enabled, null)
	scram = try(vpc_connectivity.value.sasl_scram_enabled, null)
	}
	}
	}
	}
	}

[Benbentwo]

Suggested change

	variable "vpc_connectivity_client_authentication_sasl_iam_enabled" {
	type = bool
	default = false
	description = "Enables SASL/IAM authentication for VPC connectivity"
	nullable = false
	}
	variable "vpc_connectivity_client_authentication_sasl_scram_enabled" {
	type = bool
	default = false
	description = "Enables SASL/SCRAM authentication for VPC connectivity."
	nullable = false
	}
	variable "vpc_connectivity" {
	description = <<-EOT
	Optional VPC connectivity settings. Set to null to omit the entire `vpc_connectivity` block.
	Provide booleans for SASL IAM and/or SCRAM.
	Example:
	vpc_connectivity = {
	sasl_iam_enabled = true
	sasl_scram_enabled = true
	}
	EOT
	type = object({
	sasl_iam_enabled = optional(bool)
	sasl_scram_enabled = optional(bool)
	})
	default = null
	nullable = true
	validation {
	condition = var.vpc_connectivity == null
	|| try(var.vpc_connectivity.sasl_iam_enabled, false)
	|| try(var.vpc_connectivity.sasl_scram_enabled, false)
	error_message = "When vpc_connectivity is set, enable at least one of sasl_iam_enabled or sasl_scram_enabled."
	}
	}

[Benbentwo]

/terratest