Skip to content

Conversation

kambala-decapitator
Copy link
Contributor

@kambala-decapitator kambala-decapitator commented Dec 22, 2024

Summary

Changes to recipe: opusfile/all

Motivation

Fixes building opusfile with http=True for Android

Details

Build fails due to using C99 features but compiling in C89 mode. I've opened issue in upstream xiph/opusfile#52 as I'm not sure what's the right way to proceed here (if I can blindly replace 89 with 99). In the recipe I replace 89 with 99 only for Android (because again I'm not sure if there will be any side effects on other platforms).


uilianries
uilianries previously approved these changes May 8, 2025
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kambala-decapitator Hello! 👋

Thank you for pushing PR and alerting the upstream about the case. Indeed I could reproduce your scenario: opusfile-0.12-android-error.log

And when applying your patch, it works normally for Android: opusfile-0.12-android-patched.log

I did a small change in your PR to accept settings.compiler.cstd in case defined in the profile.

I found another related issue in the upstream: xiph/opusfile#44

And as you pointed, the C99 is needed due function inline feature.

@jcar87
Copy link
Contributor

jcar87 commented Jun 20, 2025

Thanks @uilianries for providing the build logs - good for traceability.

the issues are in the Linux headers (the android Linux headers) - not the library itself.

This library appears unmaintained in terms of releases and maintainers acknowledging issues - and under those circumstances, I would discourage use

@jcar87 jcar87 merged commit 0df0fb6 into conan-io:master Jun 20, 2025
9 checks passed
@kambala-decapitator kambala-decapitator deleted the package/opusfile branch June 20, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants