Skip to content

add envisage#396

Merged
jakirkham merged 4 commits intoconda-forge:masterfrom
grlee77:envisage
Apr 28, 2016
Merged

add envisage#396
jakirkham merged 4 commits intoconda-forge:masterfrom
grlee77:envisage

Conversation

@grlee77
Copy link
Copy Markdown
Member

@grlee77 grlee77 commented Apr 18, 2016

Add envisage as required by #285.

This PR will require #391, #394 and #395 to be merged first

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly conda-forge-admin automated user.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/envisage) and found it was in an excellent condition.

@grlee77
Copy link
Copy Markdown
Member Author

grlee77 commented Apr 19, 2016

I listed the license here as BSD 3-clause, but upon further inspection there are a handful of icon images that are under a variety of other licenses. See the details in this file:
https://github.com/enthought/envisage/blob/38c1ffc40cdd0b9a2e19faed80c8f253a08c553c/image_LICENSE.txt

@grlee77 grlee77 mentioned this pull request Apr 26, 2016
@jakirkham
Copy link
Copy Markdown
Member

Could you please cherry-pick this commit ( aa7a93b ) that will fix the Windows build failure?

@jakirkham
Copy link
Copy Markdown
Member

Once the cherry-pick is done and CI passes, am more than happy to merge this.

@conda-forge-linter
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/envisage) and found it was in an excellent condition.

@grlee77
Copy link
Copy Markdown
Member Author

grlee77 commented Apr 28, 2016

looks like this is now good to go

@jakirkham
Copy link
Copy Markdown
Member

Thanks @grlee77.

@jakirkham jakirkham merged commit 055e6f5 into conda-forge:master Apr 28, 2016
@grlee77 grlee77 deleted the envisage branch June 3, 2016 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants