Skip to content

Minor fixes #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Minor fixes #2

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66a0201
fix: Do not exit function if fetching only from the first classroom f…
srevinsaju Oct 2, 2020
8cd2d48
fix: Do not attempt to check for assignments if empty courseWork
srevinsaju Oct 2, 2020
d0e9f93
fix: fallback to empty string '' instead of NoneType if description i…
srevinsaju Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions utils/gclassroom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def submissionsCallback(request_id, response, exception):

if not assignmentList:
Logger.success("No assignments due!")
return
continue

# Get submisions
for assignment in assignmentList:
Expand All @@ -109,14 +109,17 @@ def submissionsCallback(request_id, response, exception):
Logger.notice("Assignments: ")
for submission in dueAssignments:
for coursework in courseWork:
if not coursework.get('courseWork'):
continue
if coursework.get('courseWork')[0].get('id') == submission.get("courseWorkId"):
desc = ""
if len(coursework.get('courseWork')[0].get('description').split('\n')[0]) > 100:
if len(coursework.get('courseWork')[0].get('description',
'').split('\n')[0]) > 100:
desc = coursework.get('courseWork')[0].get(
'description').split('\n')[0][0:100] + "..."
else:
desc = coursework.get('courseWork')[0].get(
'description').split('\n')[0]
'description', '').split('\n')[0]

Logger.info("* " + coursework.get('courseWork')[0].get(
'title') + " (" + coursework.get('courseWork')[0].get('id') + ")")
Expand Down