Relax GTFS transfer validation and error logging#984
Merged
Conversation
ad3b35b to
397885b
Compare
ansoncfit
approved these changes
Dec 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minimal first step toward #983, consisting of cherry-picking a single commit from that PR branch. It updates GTFS loading to tolerate a wider range of transfer types in the input data, even if we're not going to use all those types in preparing the routable network. It also bypasses the referential integrity checking on transfer specificity fields that only occur on transfer rows we do not actually use, since some commonly used feeds apparently have invalid values in thousands of such rows.
I have tested this on the MBTA feed and am able to build a network and route on it.
This also demotes one log message from ERROR to INFO, since that message appears in normal operation on almost every valid input file.