Skip to content

chore: roll updated crs v3.3 containers #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 11, 2025
Merged

chore: roll updated crs v3.3 containers #376

merged 13 commits into from
Sep 11, 2025

Conversation

fzipi
Copy link
Member

@fzipi fzipi commented Sep 5, 2025 •
edited
Loading

what

  • add multiple crs versions for builds, so we provide also updated versions for previous major CRS release (v3.3.7)
  • update README with new labels for the old version
  • fix shellcheck errors ("local" doesn't exist in posix)
  • splitted configuration per major release

why

  • provide updated containers for downstream consumption

@fzipi fzipi requested a review from theseion September 5, 2025 22:20
@fzipi
fix: update config for v3.3 tests
eb76d67 
Signed-off-by: Felipe Zipitria <[email protected]>
@fzipi fzipi force-pushed the chore/update-crs-v3.3 branch from 3afcc7b to eb76d67 Compare September 5, 2025 22:45
@fzipi
Copy link
Member Author

fzipi commented Sep 6, 2025 •
edited
Loading

Ugh, the configure-rules-for-test.sh will fail because of the legacy config. Pain. Solved by splitting.

@fzipi
Copy link
Member Author

fzipi commented Sep 6, 2025 •
edited
Loading

Oh, and of course, running the tests for the latest coreruleset won't work either. Ended up splitting the config.

@fzipi fzipi force-pushed the chore/update-crs-v3.3 branch from 1126e47 to 8bf9364 Compare September 6, 2025 21:24
@fzipi
fix: add border case
9e8ff42 
Signed-off-by: Felipe Zipitria <[email protected]>
@fzipi fzipi force-pushed the chore/update-crs-v3.3 branch 2 times, most recently from d40fe70 to e5a6979 Compare September 7, 2025 14:16
@fzipi fzipi force-pushed the chore/update-crs-v3.3 branch 3 times, most recently from 7c3ebf2 to 40798f3 Compare September 7, 2025 23:28
@fzipi
fix: use per version config file
e255e35 
Signed-off-by: Felipe Zipitria <[email protected]>
@fzipi fzipi force-pushed the chore/update-crs-v3.3 branch from 40798f3 to e255e35 Compare September 7, 2025 23:43
@fzipi
Copy link
Member Author

fzipi commented Sep 7, 2025

The 4 expected tests, with the old name, will not work.

theseion
theseion requested changes Sep 9, 2025
View reviewed changes
fzipi
fzipi commented Sep 9, 2025
View reviewed changes
fzipi
fzipi commented Sep 9, 2025
View reviewed changes
fzipi
fzipi commented Sep 9, 2025
View reviewed changes
@fzipi fzipi requested a review from theseion September 9, 2025 21:12
@theseion theseion merged commit 4a9387f into main Sep 11, 2025
9 checks passed
@theseion theseion deleted the chore/update-crs-v3.3 branch September 11, 2025 13:18
@fzipi fzipi mentioned this pull request Sep 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theseion theseion theseion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fzipi @theseion