feat: use cronos store and rocksdb v9.11.2 #1200

songgaoye · 2025-09-12T11:31:31Z

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

ref crypto-org-chain/cronos-store#5

PR Checklist:

Thank you for your code, it's appreciated! :)

codecov · 2025-09-12T13:14:10Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.83%. Comparing base (b1436a5) to head (8e5ed9a).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1200      +/-   ##
==========================================
+ Coverage   31.02%   33.83%   +2.80%     
==========================================
  Files         106      114       +8     
  Lines       18910    19209     +299     
==========================================
+ Hits         5867     6499     +632     
+ Misses      12000    11634     -366     
- Partials     1043     1076      +33

Flag	Coverage Δ
integration_tests	`24.17% <100.00%> (+<0.01%)`	⬆️
integration_tests_byzantine	`11.13% <100.00%> (+<0.01%)`	⬆️
integration_tests_gov	`11.35% <100.00%> (+<0.01%)`	⬆️
integration_tests_grpc	`11.35% <100.00%> (+<0.01%)`	⬆️
integration_tests_ibc	`24.94% <100.00%> (+<0.01%)`	⬆️
integration_tests_ledger	`11.33% <100.00%> (+<0.01%)`	⬆️
integration_tests_slow	`11.33% <100.00%> (+<0.01%)`	⬆️
integration_tests_solomachine	`11.16% <100.00%> (+<0.01%)`	⬆️
integration_tests_upgrade	`11.35% <100.00%> (+<0.01%)`	⬆️
unit_tests	`12.51% <100.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

update cronos-store use go_1_24 update nix/sources.json add nix_path update nix/testenv.nix add poetry-lock ci use nixpksg 25.05 nix/rocksdb.nix

go.mod

XinyuCRO · 2025-09-16T09:49:53Z

.github/workflows/nix.yml

          submodules: true
      - uses: cachix/install-nix-action@fc6e360bedc9ee72d75e701397f0bb30dce77568 # v31.2
        with:
+          nix_path: nixpkgs=channel:nixos-unstable


if local build can pass we may not need to use unstable channel?

when I removed this, it encountered errors (it may be warnings).
https://github.com/crypto-org-chain/chain-main/actions/runs/17815005611/job/50646493618?pr=1200, open the link title.

error: … while calling the 'import' builtin at «string»:1:2: 1| (import <nixpkgs> {}).bashInteractive | ^ … while realising the context of a path … while calling the 'findFile' builtin at «string»:1:9: 1| (import <nixpkgs> {}).bashInteractive | ^ error: file 'nixpkgs' was not found in the Nix search path (add it using $NIX_PATH or -I)

I want to remove these errors; howerver, there may be better approaches.

XinyuCRO · 2025-09-16T09:56:07Z

nix/sources.json

        "description": "Convert poetry projects to nix automagically [maintainer=@adisbladis] ",
        "homepage": "",
-        "owner": "nix-community",
+        "owner": "a-sup",


for the poetry2nix wheels 404 issue, if the upstream can't apply the fix we may need to fork it and apply it on our own repo, cc @thomas-nguy

ref: nix-community/poetry2nix#1921

whats the error you are getting?

it encoutered errors
Trying to fetch with predicted URL: https://files.pythonhosted.org/packages/wheel/a/attrs/attrs-23.2.0-py3-none-any.whl curl: (22) The requested URL returned error: 404 error: builder for '/nix/store/dfnxx42m7jcqmw66m646zqx2bf0b08q6-attrs-23.2.0-py3-none-any.whl.drv' failed to produce output path for output 'out' at '/nix/store/dfnxx42m7jcqmw66m646zqx2bf0b08q6-attrs-23.2.0-py3-none-any.whl.drv.chroot/root/nix/store/wgvnnwdmhdg36kh8whl9bj4fn2m9waay-attrs-23.2.0-py3-none-any.whl' building '/nix/store/spmwnjqqr39g6mqqscg7lmkiyy8lk653-charset_normalizer-3.4.1-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.drv'... error: Cannot build '/nix/store/hgrr0704gi7f7f90cryxmcn1bzjbl8dz-python3.11-attrs-23.2.0.drv'. Reason: 1 dependency failed. Output paths: /nix/store/4xrwkcvv987ksaj2dihw8qg51s1w0zfr-python3.11-attrs-23.2.0-dist /nix/store/jqdgp3rxzjdfvlxr3ys3z1c284bf2nl9-python3.11-attrs-23.2.0 error: Cannot build '/nix/store/0v631l33p9py55yf51q9vx0s0j2na805-python3-3.11.13-env.drv'. Reason: 1 dependency failed. Output paths: /nix/store/aafs4jb09k5nzkfp0v6sb655n8fq2vc9-python3-3.11.13-env error: Cannot build '/nix/store/xcz2rhc7aj3wazhpqvncw6554gxlh1qd-lint-ci.drv'. Reason: 1 dependency failed. Output paths: /nix/store/b0m5ck787xi5a1mw9wgf9508jq470f58-lint-ci error: build of '/nix/store/jaz1q35nrs6vx75f87k6xqs500xhkd3p-stdenv-linux.drv', '/nix/store/xcz2rhc7aj3wazhpqvncw6554gxlh1qd-lint-ci.drv' failed make: *** [Makefile:171: lint-ci] Error 1

songgaoye · 2025-09-18T00:53:01Z

nix/default.nix

    (import ./build_overlay.nix)
    (pkgs: prev: {
-      go = pkgs.go_1_23;
+      go = pkgs.go_1_24;


it encountered errors
1030| go_1_23 = throw "Go 1.23 is end-of-life and 'go_1_23' has been removed. Please use a newer Go toolchain."; # Added 2025-08-13 | ^ 1031| gogs = throw '' error: Go 1.23 is end-of-life and 'go_1_23' has been removed. Please use a newer Go toolchain. ,
so I updated it.

songgaoye · 2025-09-18T00:59:21Z

nix/rocksdb.nix

    "-DFAIL_ON_WARNINGS=${if stdenv.hostPlatform.isMinGW then "NO" else "YES"}"
-  ] ++ lib.optional (!enableShared) "-DROCKSDB_BUILD_SHARED=0";
+  ]
+  ++ lib.optionals stdenv.hostPlatform.isWindows [


it encountered errors
rocksdb-x86_64-w64-mingw32> /build/source/port/win/env_win.cc:921:3: error: 'FILE_ID_INFO' was not declared in this scope; did you mean 'SIID_INFO'? rocksdb-x86_64-w64-mingw32> 921 | FILE_ID_INFO FileInfo_1; rocksdb-x86_64-w64-mingw32> | ^~~~~~~~~~~~ rocksdb-x86_64-w64-mingw32> | SIID_INFO rocksdb-x86_64-w64-mingw32> /build/source/port/win/env_win.cc:922:54: error: 'FileIdInfo' was not declared in this scope; did you mean 'FileNameInfo'? rocksdb-x86_64-w64-mingw32> 922 | BOOL result = GetFileInformationByHandleEx(file_1, FileIdInfo, &FileInfo_1, rocksdb-x86_64-w64-mingw32> | ^~~~~~~~~~ rocksdb-x86_64-w64-mingw32> | FileNameInfo rocksdb-x86_64-w64-mingw32> /build/source/port/win/env_win.cc:922:67: error: 'FileInfo_1' was not declared in this scope rocksdb-x86_64-w64-mingw32> 922 | BOOL result = GetFileInformationByHandleEx(file_1, FileIdInfo, &FileInfo_1, rocksdb-x86_64-w64-mingw32> | ^~~~~~~~~~ rocksdb-x86_64-w64-mingw32> /build/source/port/win/env_win.cc:931:15: error: expected ';' before 'FileInfo_2' rocksdb-x86_64-w64-mingw32> 931 | FILE_ID_INFO FileInfo_2; rocksdb-x86_64-w64-mingw32> | ^~~~~~~~~~~ rocksdb-x86_64-w64-mingw32> | ; rocksdb-x86_64-w64-mingw32> /build/source/port/win/env_win.cc:932:62: error: 'FileInfo_2' was not declared in this scope
so I updated it.

JayT106 · 2025-09-18T02:35:40Z

go.mod

-	github.com/crypto-org-chain/cronos/versiondb => github.com/crypto-org-chain/cronos/versiondb v0.0.0-20241028093154-0f94930c27ce
+	github.com/crypto-org-chain/cronos-store/memiavl => github.com/crypto-org-chain/cronos-store/memiavl v0.0.0-20250912125026-c998a90e2881
+	github.com/crypto-org-chain/cronos-store/store => github.com/crypto-org-chain/cronos-store/store v0.0.0-20250912125026-c998a90e2881
+	github.com/crypto-org-chain/cronos-store/versiondb => github.com/crypto-org-chain/cronos-store/versiondb v0.0.0-20250912125026-c998a90e2881


Should we use github.com/crypto-org-chain/cronos-store instead of these 3 independent components? Do we bump these components' version separately or just the cronos-store version?

I see previously bump these component's version, but actually they use the same commit hash.

socket-security · 2025-09-18T07:12:28Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	golang/github.com/linxGnu/grocksdb@v1.9.2 ⏵ v1.9.10-0.20250331012329-9d5f074653d1	⁺¹
	golang/github.com/crypto-org-chain/cronos-store/versiondb@v0.0.0-20250912125026-c998a90e2881
	golang/github.com/crypto-org-chain/cronos-store/store@v0.0.0-20250912125026-c998a90e2881

View full report

songgaoye requested a review from a team as a code owner September 12, 2025 11:31

songgaoye requested review from thomas-nguy and XinyuCRO and removed request for a team September 12, 2025 11:31

This comment has been minimized.

Sign in to view

github-actions bot added nix build and removed build labels Sep 12, 2025

github-actions bot added ci and removed ci labels Sep 12, 2025

songgaoye force-pushed the song/use_cronos_store branch 3 times, most recently from f1c3be3 to af0a887 Compare September 12, 2025 17:24

github-actions bot added ci and removed ci labels Sep 12, 2025

songgaoye force-pushed the song/use_cronos_store branch from 780f284 to 39ea8ae Compare September 13, 2025 02:05

songgaoye marked this pull request as draft September 13, 2025 03:20

songgaoye force-pushed the song/use_cronos_store branch 8 times, most recently from 0651ea1 to d0415ab Compare September 15, 2025 10:06

songgaoye added 3 commits September 16, 2025 10:49

feat: use cronos-store and rocksdb 9.11.2

c4722ad

update gomod2nix.toml

f10e0cd

update cronos-store use go_1_24 update nix/sources.json add nix_path update nix/testenv.nix add poetry-lock ci use nixpksg 25.05 nix/rocksdb.nix

fmt nix

5de5bbe

remove poetry.lock

332fe51

songgaoye force-pushed the song/use_cronos_store branch from 529449b to 332fe51 Compare September 16, 2025 02:54

songgaoye added 4 commits September 16, 2025 11:00

revert poetry

ed9c7ca

update gomod2nix.toml

55c5bcc

update nix/rocksdb.nix

7e9847a

add changelog

e5e4103

songgaoye marked this pull request as ready for review September 16, 2025 03:54

update rocksdb.nix

1bd952e

XinyuCRO reviewed Sep 16, 2025

View reviewed changes

songgaoye commented Sep 18, 2025

View reviewed changes

songgaoye added 3 commits September 18, 2025 09:11

fix link

99f830a

remove nix_path

184ed3d

revert remove nix_path

1bc1744

songgaoye requested review from XinyuCRO, JayT106 and randy-cro September 18, 2025 01:28

JayT106 reviewed Sep 18, 2025

View reviewed changes

Merge branch 'master' into song/use_cronos_store

8ac225d

songgaoye added 2 commits September 19, 2025 09:14

Merge branch 'master' into song/use_cronos_store

d13c9fb

nix_path use nixos-25.05

8e5ed9a

songgaoye marked this pull request as draft September 19, 2025 02:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: use cronos store and rocksdb v9.11.2 #1200

feat: use cronos store and rocksdb v9.11.2 #1200

Uh oh!

songgaoye commented Sep 12, 2025 •

edited

Loading

Uh oh!

This comment has been minimized.

codecov bot commented Sep 12, 2025 •

edited

Loading

Uh oh!

Uh oh!

XinyuCRO Sep 16, 2025

Uh oh!

songgaoye Sep 18, 2025 •

edited

Loading

Uh oh!

XinyuCRO Sep 16, 2025

Uh oh!

thomas-nguy Sep 17, 2025

Uh oh!

songgaoye Sep 18, 2025 •

edited

Loading

Uh oh!

songgaoye Sep 18, 2025 •

edited

Loading

Uh oh!

songgaoye Sep 18, 2025 •

edited

Loading

Uh oh!

JayT106 Sep 18, 2025

Uh oh!

songgaoye Sep 19, 2025

Uh oh!

socket-security bot commented Sep 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

feat: use cronos store and rocksdb v9.11.2 #1200

Are you sure you want to change the base?

feat: use cronos store and rocksdb v9.11.2 #1200

Uh oh!

Conversation

songgaoye commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist:

Uh oh!

This comment has been minimized.

codecov bot commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

XinyuCRO Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

songgaoye Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

XinyuCRO Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

thomas-nguy Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

songgaoye Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

songgaoye Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

songgaoye Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JayT106 Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

songgaoye Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

socket-security bot commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

songgaoye commented Sep 12, 2025 •

edited

Loading

codecov bot commented Sep 12, 2025 •

edited

Loading

songgaoye Sep 18, 2025 •

edited

Loading

songgaoye Sep 18, 2025 •

edited

Loading

songgaoye Sep 18, 2025 •

edited

Loading

songgaoye Sep 18, 2025 •

edited

Loading

socket-security bot commented Sep 18, 2025 •

edited

Loading