Skip to content

Conversation

thomas-nguy
Copy link
Collaborator

@thomas-nguy thomas-nguy commented Aug 20, 2025

Description

Optimise staking endblocker

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@thomas-nguy thomas-nguy requested a review from a team as a code owner August 20, 2025 08:38
@thomas-nguy thomas-nguy requested review from XinyuCRO and songgaoye and removed request for a team August 20, 2025 08:38
Copy link
Contributor

coderabbitai bot commented Aug 20, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thomas-nguy thomas-nguy changed the title feat: optimize end blocker by removing unnecessary address conversion feat: remove unnecessary address conversion at endblocker Aug 20, 2025
Copy link

socket-security bot commented Sep 22, 2025

Copy link

socket-security bot commented Sep 22, 2025

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@randy-cro randy-cro changed the title feat: remove unnecessary address conversion at endblocker perf: optimise staking endblocker Sep 25, 2025
randy-cro and others added 9 commits September 25, 2025 22:22
* update lint

* to be reverted: enable linter in this PR

* revert

* fix lint

* fix more lint

* add changelog

* fix lint

* fix lint

* remove comment

* fix comments
* [#1850](https://github.com/crypto-org-chain/cronos/pull/1850) Optimize staking endblocker by retrieving iterators in parallel and reducing range of iteration.
* [#1850](https://github.com/crypto-org-chain/cronos/pull/1850) Upgrade to RocksDB version 10.4.2 and enable asyncIO.
* [#1850](https://github.com/crypto-org-chain/cronos/pull/1850) Optimize staking endblocker removing unnecessary address conversion.

Copy link
Contributor

@JayT106 JayT106 Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use just one line, because it's the same PR? Or do separate lines with indents with just one PR link?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants