-
Notifications
You must be signed in to change notification settings - Fork 273
perf: optimise staking endblocker #1850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/v1.4.x
Are you sure you want to change the base?
perf: optimise staking endblocker #1850
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
* update lint * to be reverted: enable linter in this PR * revert * fix lint * fix more lint * add changelog * fix lint * fix lint * remove comment * fix comments
* [#1850](https://github.com/crypto-org-chain/cronos/pull/1850) Optimize staking endblocker by retrieving iterators in parallel and reducing range of iteration. | ||
* [#1850](https://github.com/crypto-org-chain/cronos/pull/1850) Upgrade to RocksDB version 10.4.2 and enable asyncIO. | ||
* [#1850](https://github.com/crypto-org-chain/cronos/pull/1850) Optimize staking endblocker removing unnecessary address conversion. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use just one line, because it's the same PR? Or do separate lines with indents with just one PR link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM
Description
Optimise staking endblocker
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)