Skip to content

Conversation

thomas-nguy
Copy link

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@thomas-nguy thomas-nguy requested a review from a team as a code owner September 5, 2025 04:03
@thomas-nguy thomas-nguy requested review from XinyuCRO and randy-cro and removed request for a team September 5, 2025 04:03
@thomas-nguy thomas-nguy marked this pull request as draft September 5, 2025 04:03
@github-actions github-actions bot added the evm label Sep 5, 2025
Copy link

github-actions bot commented Sep 5, 2025

@thomas-nguy your pull request is missing a changelog!

@thomas-nguy thomas-nguy force-pushed the thomas/eip-2935-support branch from 932e118 to 382a950 Compare September 5, 2025 05:12
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

❌ Patch coverage is 72.09302% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.95%. Comparing base (99c354d) to head (88ff389).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
x/evm/keeper/keeper.go 70.00% 8 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #722      +/-   ##
===========================================
+ Coverage    45.91%   45.95%   +0.03%     
===========================================
  Files          187      187              
  Lines        18918    18950      +32     
===========================================
+ Hits          8686     8708      +22     
- Misses        9447     9454       +7     
- Partials       785      788       +3     
Files with missing lines Coverage Δ
x/evm/keeper/state_transition.go 71.06% <100.00%> (ø)
x/evm/types/params.go 38.35% <100.00%> (+0.85%) ⬆️
x/evm/keeper/keeper.go 80.58% <70.00%> (-2.87%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thomas-nguy
Copy link
Author

This PR is blocked by missing pre-install functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant