Skip to content

Improve handling of Currency update responses#82

Open
cameronsstone wants to merge 2 commits intodeanishe:masterfrom
cameronsstone:master
Open

Improve handling of Currency update responses#82
cameronsstone wants to merge 2 commits intodeanishe:masterfrom
cameronsstone:master

Conversation

@cameronsstone
Copy link
Copy Markdown

@cameronsstone cameronsstone commented Dec 10, 2020

There are two commits here:

  1. Generically reject any currency updates unless both are true:
    1. the currency is in CURRENCIES or CRYPTO_CURRENCIES
    2. the rate is a number.
  2. Explicitly handle throttling responses from Cryptocompare.com's API which unfortunately use a HTTP 200 instead of a 429 or similar.

This should help with #74 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant