fix: resolve #2807 — Possible flaky test in Endo#3166
Open
tudragon154203 wants to merge 2 commits intoendojs:masterfrom
Open
fix: resolve #2807 — Possible flaky test in Endo#3166tudragon154203 wants to merge 2 commits intoendojs:masterfrom
tudragon154203 wants to merge 2 commits intoendojs:masterfrom
Conversation
Fixes endojs#2807 Signed-off-by: tudragon154203 <76395825+tudragon154203@users.noreply.github.com>
Fixes endojs#2807 Signed-off-by: tudragon154203 <76395825+tudragon154203@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: resolve #2807 — Possible flaky test in Endo
Problem
Severity:
Medium| File:packages/ses/test/test-importNow.jsTests that verify importNow behavior may be asserting on ordering that isn't guaranteed by the implementation, or may be passing locally due to favorable timing but failing in CI where execution timing varies.
Solution
Review tests that involve multiple importNow calls or check execution order. Ensure tests properly await all async operations before asserting. Add explicit synchronization points where needed. Consider using a deterministic test helper that waits for all queued jobs to complete before checking results. If testing ordering, ensure the test explicitly sets up the scenario rather than relying on implicit timing.
Changes
packages/ses/test/test-importNow.js(new)packages/ses/src/jobQueue.js(new)Testing
Generated by ContribAI v5.15.0