feat: added carto admin authorization#575
Closed
otsybizov wants to merge 1 commit intomainnet-stagingfrom
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the Cartographer handler’s operational pause/resume controls by adding admin-token auth and persisting pause state in the database so it survives restarts, while also refactoring secret verification and wiring the new token into staging infrastructure config.
Changes:
- Replace
verifyWebhookSecretwith a genericverifySecrethelper and update tests/usages accordingly. - Add authenticated
/pauseand/resumeendpoints that persist pause state via a DB checkpoint and restore it on startup. - Plumb
CARTOGRAPHER_ADMIN_TOKENthrough handler config and staging Terraform/secrets.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/agents/cartographer/handler/src/webhooks/webhookHandler.ts | Renames secret verification helper and expands webhook routing debug logging. |
| packages/agents/cartographer/handler/test/webhooks/webhookHandler.spec.ts | Updates unit tests to use verifySecret. |
| packages/agents/cartographer/handler/src/server.ts | Adds admin-token auth for pause/resume + DB checkpoint persistence; uses verifySecret for webhook auth. |
| packages/agents/cartographer/handler/test/server.spec.ts | Adds auth coverage for pause/resume and asserts DB checkpoint persistence. |
| packages/agents/cartographer/handler/src/init.ts | Extends handler config to include admin token from env var. |
| packages/agents/cartographer/handler/src/index.ts | Restores paused state from DB checkpoint at startup. |
| ops/mainnet/staging/backend/variables.tf | Adds Terraform variable for the admin token. |
| ops/mainnet/staging/backend/config.tf | Injects CARTOGRAPHER_ADMIN_TOKEN into handler environment variables. |
| ops/env/mainnet/backend/secrets.staging.json | Adds encrypted staging secret for the admin token. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes CONG-XXX