fix: expose the lighthouse queue redis over PrivateLink#599
Closed
otsybizov wants to merge 1 commit intomainnet-stagingfrom
Closed
fix: expose the lighthouse queue redis over PrivateLink#599otsybizov wants to merge 1 commit intomainnet-stagingfrom
otsybizov wants to merge 1 commit intomainnet-stagingfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR exposes the Lighthouse queue Redis instance to the staging backend VPC via AWS PrivateLink, and updates the mqclient Redis URL parsing to support TLS SNI overrides required when connecting through PrivateLink endpoint DNS.
Changes:
- Add Terraform PrivateLink “provider” (NLB + endpoint service) and “consumer” (interface endpoint + SG) modules.
- Wire mainnet staging core to publish an endpoint service for the Lighthouse queue Redis, and wire staging backend to consume it.
- Extend
parseRedisUrlto support?tlsServername=and add ioredis connection tuning defaults.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/adapters/mqclient/src/index.ts | Supports tlsServername query param for correct TLS SNI when connecting via PrivateLink DNS; adds retry/timeout/keepalive defaults. |
| ops/modules/privatelink/provider/main.tf | Creates internal NLB + TCP target group + VPC Endpoint Service backed by IPs resolved from DNS. |
| ops/modules/privatelink/provider/variables.tf | Defines inputs for provider-side PrivateLink resources (VPC/subnets/target address+port). |
| ops/modules/privatelink/provider/outputs.tf | Exposes endpoint service name and NLB ARN for consumers. |
| ops/modules/privatelink/consumer/main.tf | Creates interface VPC endpoint and security group to access the endpoint service. |
| ops/modules/privatelink/consumer/variables.tf | Defines inputs for consumer-side endpoint creation and access control. |
| ops/modules/privatelink/consumer/outputs.tf | Exposes endpoint DNS names and endpoint ID for downstream configuration. |
| ops/mainnet/staging/core/main.tf | Instantiates provider module to expose Lighthouse queue Redis over PrivateLink. |
| ops/mainnet/staging/core/outputs.tf | Exposes endpoint service name plus Redis connection components for backend consumption. |
| ops/mainnet/staging/backend/main.tf | Instantiates consumer module to create interface endpoint to core’s endpoint service. |
| ops/mainnet/staging/backend/config.tf | Updates REDIS_URL to use the PrivateLink DNS name and sets tlsServername to the real Redis hostname. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+66
to
+69
| resource "aws_vpc_endpoint_service" "this" { | ||
| acceptance_required = false | ||
| network_load_balancer_arns = [aws_lb.this.arn] | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes CONG-XXX