-
Notifications
You must be signed in to change notification settings - Fork 5
fix: notify lighthouse from backfill loop when new subgraph data is found #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+322
−54
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| import { | ||
| updateHubInvoices as _updateHubInvoices, | ||
| updateHubDeposits as _updateHubDeposits, | ||
| updateOriginIntents as _updateOriginIntents, | ||
| updateDestinationIntents as _updateDestinationIntents, | ||
| updateHubIntents as _updateHubIntents, | ||
| updateSettlementIntents as _updateSettlementIntents, | ||
| updateOrders as _updateOrders, | ||
| updateMessages as _updateMessages, | ||
| updateQueues as _updateQueues, | ||
| updateHubSpokeMeta as _updateHubSpokeMeta, | ||
| updateProtocolUpdateLogs as _updateProtocolUpdateLogs, | ||
| updateMessageStatus as _updateMessageStatus, | ||
| updateAssets as _updateAssets, | ||
| updateDepositors as _updateDepositors, | ||
| } from '@chimera-monorepo/cartographer-core'; | ||
|
|
||
| export const updateHubInvoices = _updateHubInvoices; | ||
| export const updateHubDeposits = _updateHubDeposits; | ||
| export const updateOriginIntents = _updateOriginIntents; | ||
| export const updateDestinationIntents = _updateDestinationIntents; | ||
| export const updateHubIntents = _updateHubIntents; | ||
| export const updateSettlementIntents = _updateSettlementIntents; | ||
| export const updateOrders = _updateOrders; | ||
| export const updateMessages = _updateMessages; | ||
| export const updateQueues = _updateQueues; | ||
| export const updateHubSpokeMeta = _updateHubSpokeMeta; | ||
| export const updateProtocolUpdateLogs = _updateProtocolUpdateLogs; | ||
| export const updateMessageStatus = _updateMessageStatus; | ||
| export const updateAssets = _updateAssets; | ||
| export const updateDepositors = _updateDepositors; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updateMessagesis treated as a single boolean signal, but here any non-zero count triggers SETTLEMENT + FILL + SOLANA notifications. SinceupdateMessagescan return >0 for spoke Intent/Fill messages (and non-Solana hub messages), this can enqueue unnecessary settlement/solana work. Consider returning more granular info fromupdateMessages(e.g., counts per message type / per queue or aSetof queues to notify), or splitting hub vs spoke message updates so backfill only notifies the queues that actually had new relevant data (similar toprocessHubMessage/processSpokeMessagenotification behavior).