fix: use int32 bounds for semantic sensor observation space#2224
Open
xiaosq2000 wants to merge 2 commits intofacebookresearch:mainfrom
Open
fix: use int32 bounds for semantic sensor observation space#2224xiaosq2000 wants to merge 2 commits intofacebookresearch:mainfrom
xiaosq2000 wants to merge 2 commits intofacebookresearch:mainfrom
Conversation
The semantic sensor's `_get_observation_space` declared `dtype=np.int32` but used `np.iinfo(np.uint32)` for `low`/`high` bounds. This was silently accepted by NumPy <2.0 (wrapping uint32 max to -1), but NumPy 2.0+ enforces strict integer bounds checking and raises OverflowError. Align `low` and `high` with the declared int32 dtype. This is consistent with `get_observation`, which already casts to int32. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
meta-cla
Bot
added
the
CLA Signed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
>=1.26.4OverflowErrorinHabitatSimSemanticSensor._get_observation_spacewhen running with NumPy 2.0+The semantic sensor declared
dtype=np.int32but usednp.iinfo(np.uint32)forlow/highbounds. NumPy <2.0 silently wrappeduint32max (4294967295) to-1; NumPy 2.0+ enforces strict integer bounds checking and raises:Test plan
semantic_sensorenabled under NumPy 2.0+int32and bounds are within range🤖 Generated with Claude Code