feat: add gravatar configuration to cfp settings by sarafarajnasardi · Pull Request #2128 · fossasia/eventyay

sarafarajnasardi · 2026-01-26T12:07:15Z

Description
Implemented a new setting to enable/disable Gravatar support for speaker profile pictures in the Call for Participation (CfP) flow. This allows organizers to control whether speakers can retrieve their avatars via Gravatar.

Changes
Backend: Added cfp_enable_gravatar setting to the CfP model and updated the speaker profile form to respect it.
Organizer UI: Added a Settings column to the CfP configuration table with a toggle to enable/disable Gravatar.
Speaker UI: Updated the avatar template to conditionally render Gravatar options and fixed the preview visibility logic.

fixes #2119

Screencast.From.2026-01-26.18-07-12.mp4

sourcery-ai

Sorry @sarafarajnasardi, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

Copilot

Pull request overview

This PR introduces an event-level setting to enable or disable Gravatar usage for speaker profile pictures in the CfP flow, and wires it through the admin UI, forms, and templates so organisers can control whether Gravatar is offered.

Changes:

Added a cfp_enable_gravatar setting on CfP (with an enable_gravatar property) and surfaced it via CfPSettingsForm and the organiser “Speaker Information” settings table, including a dedicated toggle in the “Profile picture” row.
Updated SpeakerProfileForm and the avatar template to respect the new setting by conditionally showing the Gravatar checkbox, adjusting the “required avatar” validation message, and fixing avatar preview visibility and fallback src logic when only Gravatar is used.
Tightened the question toggle JavaScript to only attach AJAX handlers to elements that carry data-question-id, and added a defensive guard in the form-page toggle handler to avoid errors when related elements are missing.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`app/eventyay/base/models/cfp.py`	Adds `cfp_enable_gravatar` to the default CfP settings and a new `enable_gravatar` property that drives the rest of the Gravatar feature, defaulting to enabled for existing and new events.
`app/eventyay/orga/forms/cfp.py`	Extends `CfPSettingsForm` with a `cfp_enable_gravatar` BooleanField, initialised from `CfP.enable_gravatar`, and persists it into `cfp.settings` during save.
`app/eventyay/orga/templates/orga/cfp/forms.html`	Adds a “Settings” column to proposal and speaker information tables and inserts a toggle-style checkbox for `cfp_enable_gravatar` in the “Profile picture” row.
`app/eventyay/person/forms/profile.py`	Makes the speaker profile form drop the `get_gravatar` field when Gravatar is disabled and adjusts the avatar-required validation message based on `cfp.enable_gravatar`.
`app/eventyay/common/templates/common/avatar.html`	Conditionally renders the Gravatar checkbox and preview based on `request.event.cfp.enable_gravatar`, and updates the preview visibility and `img` `src` fallback logic for Gravatar-only avatars.
`app/eventyay/static/orga/js/questionToggles.js`	Restricts AJAX toggle handlers to elements with `data-question-id` and adds a null-check guard in the form-page toggle logic to avoid accessing missing hidden inputs or dropdowns.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

app/eventyay/base/models/cfp.py

mariobehling

Looks good, but we also need a description text in front of the toggle. Please add "Enable Gravatar".

sarafarajnasardi · 2026-01-26T16:52:05Z

added

sarafarajnasardi · 2026-01-27T02:52:33Z

@mariobehling Test coverage added for enable_gravatar property.

Replace direct user.avatar.url access with avatar_url property for cleaner code while preserving gravatar functionality. Signed-off-by: Sara Faraj <sarafaraj@users.noreply.github.com>

mariobehling

Please resolve conflicts.

sarafarajnasardi · 2026-02-17T13:30:16Z

@mariobehling I have resolved all the conflicts...

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 9 comments.

app/eventyay/orga/templates/orga/cfp/forms.html

app/tests/talk/submission/test_cfp_gravatar.py

app/eventyay/orga/templates/orga/cfp/forms.html

+                            <td class="text-center">
+                                <span class="mr-1">{% translate "Enable Gravatar" %}</span>
+                                <label class="toggle-switch" aria-label="{% translate "Enable Gravatar" %}">
+                                    {{ sform.cfp_enable_gravatar }}
+                                    <span class="toggle-slider"></span>


app/eventyay/orga/templates/orga/cfp/forms.html

app/eventyay/common/templates/common/avatar.html

app/tests/talk/submission/test_cfp_gravatar.py

ArnavBallinCode

Please address the above requested changes.

mariobehling

Thanks for the contribution. I reviewed the diff in detail. The overall feature makes sense, and the main Gravatar setting flow across model, organiser form, speaker form, and avatar template looks good.

Before merge, please tighten the scope of this PR. The changes in questionToggles.js and the broader tests/talk/conftest.py refactor do not appear to be directly related to the Gravatar feature and make the review harder. Please move those into separate PRs unless they are strictly required here.

In addition, please help us keep the contribution process efficient:

Avoid long running PRs. They become harder to review and manage over time and slow down the overall PR queue.
Focus on finishing and getting existing PRs merged before opening new ones.
As a guideline, contributors should typically not have more than 3 open PRs at the same time.

Signed-off-by: Sarafaraj Nasardi <sarafarajnasardi786@gmail.com>

sarafarajnasardi · 2026-03-22T07:33:31Z

Thank you for review and giving feedback. I have done the changes which you told and also made PR more clean. I will keep in mind to not add extra things in PR next time. Please tell if anything more is needed from my side...

- Implemented professional 9-column layout for Speaker Information table - Added explicit column widths for robust alignment - Restored 'Enable Gravatar' label text for better clarity - Refactored fav-button.js to replace unsafe innerHTML with safe DOM manipulation Signed-off-by: Sarafaraj Nasardi <sarafarajnasardi786@gmail.com>

feat: add gravatar configuration to cfp settings

a83f54c

github-project-automation bot added this to Eventyay Next Jan 26, 2026

github-project-automation bot moved this to Backlog in Eventyay Next Jan 26, 2026

sourcery-ai bot reviewed Jan 26, 2026

View reviewed changes

sarafarajnasardi marked this pull request as ready for review January 26, 2026 12:24

sarafarajnasardi added 2 commits January 26, 2026 17:56

fix: update question toggles JS to prevent unintended AJAX calls

1d6cf7e

fix: resolve TemplateSyntaxError in avatar.html

0ffa5dc

MukundC25 requested a review from Copilot January 26, 2026 13:58

Copilot started reviewing on behalf of MukundC25 January 26, 2026 13:58 View session

Copilot AI reviewed Jan 26, 2026

View reviewed changes

app/eventyay/base/models/cfp.py Show resolved Hide resolved

Merge branch 'dev' into 2119

4cd21f4

mariobehling requested changes Jan 26, 2026

View reviewed changes

fix: resolve TemplateSyntaxError in avatar.html

822d883

sarafarajnasardi force-pushed the 2119 branch from 6c40edc to 822d883 Compare January 26, 2026 16:49

sarafarajnasardi requested a review from mariobehling January 26, 2026 16:58

test: add coverage for enable_gravatar property

bebe2e0

refactor: use avatar_url property in avatar template

7fc0439

Replace direct user.avatar.url access with avatar_url property for cleaner code while preserving gravatar functionality. Signed-off-by: Sara Faraj <sarafaraj@users.noreply.github.com>

sarafarajnasardi force-pushed the 2119 branch 2 times, most recently from 9ec3600 to 7fc0439 Compare February 8, 2026 13:23

Merge branch 'enext' into 2119

9e756f1

mariobehling requested changes Feb 17, 2026

View reviewed changes

sarafarajnasardi force-pushed the 2119 branch 2 times, most recently from 105164f to 9e756f1 Compare February 17, 2026 13:09

Merge branch 'dev' into 2119

37fc342

ArnavBallinCode requested a review from Copilot March 18, 2026 10:04

Copilot started reviewing on behalf of ArnavBallinCode March 18, 2026 10:05 View session

Copilot AI reviewed Mar 18, 2026

View reviewed changes

ArnavBallinCode suggested changes Mar 18, 2026

View reviewed changes

mariobehling requested changes Mar 20, 2026

View reviewed changes

mariobehling and others added 2 commits March 20, 2026 14:23

Merge branch 'dev' into 2119

9a62283

fix: clean up PR review feedback and tighten scope

4bc6e0e

Signed-off-by: Sarafaraj Nasardi <sarafarajnasardi786@gmail.com>

sarafarajnasardi force-pushed the 2119 branch from 63f77a7 to 4bc6e0e Compare March 22, 2026 07:24

sarafarajnasardi force-pushed the 2119 branch from 84fd403 to f6810e7 Compare March 22, 2026 08:11

sarafarajnasardi force-pushed the 2119 branch from f6810e7 to 8a525a7 Compare March 22, 2026 08:14

Merge branch 'dev' into 2119

3723875

Conversation

sarafarajnasardi commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

mariobehling left a comment

Choose a reason for hiding this comment

Uh oh!

sarafarajnasardi commented Jan 26, 2026

Uh oh!

sarafarajnasardi commented Jan 27, 2026

Uh oh!

mariobehling left a comment

Choose a reason for hiding this comment

Uh oh!

sarafarajnasardi commented Feb 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ArnavBallinCode left a comment

Choose a reason for hiding this comment

Uh oh!

mariobehling left a comment

Choose a reason for hiding this comment

Uh oh!

sarafarajnasardi commented Mar 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sarafarajnasardi commented Jan 26, 2026 •

edited

Loading