fix: add username truncation for common dashboard dropdown #2964
Merged
Saksham-Sirohi merged 2 commits intofossasia:devfrom Mar 31, 2026
Merged
fix: add username truncation for common dashboard dropdown #2964Saksham-Sirohi merged 2 commits intofossasia:devfrom
Saksham-Sirohi merged 2 commits intofossasia:devfrom
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideImplements username truncation in the common profile dropdown by switching from displaying the full name directly to using a reusable short_user_label template filter, and ensuring the relevant template tag library is loaded. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider exposing the full
get_full_namevia atitleattribute or similar on the<summary>or icon so truncated labels remain accessible (e.g., for screen readers and hover tooltips). - Ensure the
short_user_labelfilter gracefully handles cases whererequest.useris anonymous or missing profile fields, since this template previously relied onget_full_namewhich is defined only for authenticated users.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider exposing the full `get_full_name` via a `title` attribute or similar on the `<summary>` or icon so truncated labels remain accessible (e.g., for screen readers and hover tooltips).
- Ensure the `short_user_label` filter gracefully handles cases where `request.user` is anonymous or missing profile fields, since this template previously relied on `get_full_name` which is defined only for authenticated users.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Collaborator
Author
ArnavBallinCode
approved these changes
Mar 25, 2026
mariobehling
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes part of #2965
Summary by Sourcery
New Features: