Skip to content

Fix: update login button text to 'Log in with email' for consistency#3108

Closed
Harshit-0018 wants to merge 2 commits intofossasia:devfrom
Harshit-0018:fix-login-button-text
Closed

Fix: update login button text to 'Log in with email' for consistency#3108
Harshit-0018 wants to merge 2 commits intofossasia:devfrom
Harshit-0018:fix-login-button-text

Conversation

@Harshit-0018
Copy link
Copy Markdown

@Harshit-0018 Harshit-0018 commented Mar 31, 2026

Fixes #3099

  • Updated "Login with Email" to "Log in with email"
  • Ensures consistent login button text across UI

Summary by Sourcery

Bug Fixes:

  • Correct inconsistent login button label text on the email login option.

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Mar 31, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Standardizes the login button label to "Log in with email" and switches to the {% trans %} tag for this string to ensure consistent, localizable UI copy.

File-Level Changes

Change Details Files
Standardize and properly mark the email login button text for translation.
  • Change button label text from "Login with Email" to "Log in with email" to match desired copy style
  • Replace {% translate %} with {% trans %} for this string to align with the template’s translation tag usage
  • Keep button structure, attributes, and conditional login provider logic unchanged
app/eventyay/eventyay_common/templates/eventyay_common/auth/_login_options.html

Assessment against linked issues

Issue Objective Addressed Explanation
#3099 Update the login page button text from 'Login with Email' to 'Log in with email' to match the wording used elsewhere in the UI.
#3099 Ensure consistent authentication-related button wording across the UI by aligning this button text with existing 'Log in' phrasing.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • In this template you not only changed the button text but also switched the i18n tag from {% translate %} to {% trans %}—if the rest of the codebase favors one form, consider using the same tag here for consistency and easier maintenance.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In this template you not only changed the button text but also switched the i18n tag from `{% translate %}` to `{% trans %}`—if the rest of the codebase favors one form, consider using the same tag here for consistency and easier maintenance.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Harshit-0018
Copy link
Copy Markdown
Author

Thank you for reviewing! I would be happy to make any required changes.

@Harshit-0018
Copy link
Copy Markdown
Author

Thanks for the feedback! I have updated the code to use the consistent {% translate %} tag as suggested.

@mariobehling
Copy link
Copy Markdown
Member

We are closing this PR.

This PR does not meet the minimum requirements for review.

For UI or workflow-related changes, we require clear evidence that the solution works as intended. This includes:

  • screenshots showing before and after behavior
  • a screencast demonstrating the full user flow
  • clear test steps and explanation of what was validated

None of this has been provided here.

Without this information, reviewers would need to reproduce and verify the changes themselves, which shifts the responsibility from the contributor to the reviewer. This is not acceptable.

Please ensure that future PRs are complete, properly tested in a running environment, and include all required documentation and visual proof before submission.

We are happy to review once these requirements are met.

@github-project-automation github-project-automation bot moved this from Backlog to Done in Eventyay Next Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Inconsistent button text on login page

2 participants