fix(events/org): patch event creation API and organizer deletion#3122
Merged
mariobehling merged 2 commits intofossasia:devfrom Apr 1, 2026
Merged
fix(events/org): patch event creation API and organizer deletion#3122mariobehling merged 2 commits intofossasia:devfrom
mariobehling merged 2 commits intofossasia:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts default event settings to ensure API-created events behave consistently in the UI, and hardens organizer/event deletion flows to avoid protected-relation failures and provide better operational visibility during deletions.
Changes:
- Add a default
create_for='all'setting so events created without explicit configuration still expose Talks-related navigation. - Improve organizer deletion reliability by clearing
LogEntry.api_tokenreferences before deleting teams/tokens, and add deletion-stage logging. - Reduce deletion failures/timeouts by detaching queued mail references before deleting event mail templates, plus add deletion-stage logging in event cleanup.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| app/eventyay/control/views/organizer_views/organizer_view.py | Adds start/finish and protected-relation logging around organizer deletion. |
| app/eventyay/base/settings.py | Adds create_for default and minor formatting cleanup for serializer helpers / validation blocks. |
| app/eventyay/base/models/organizer.py | Adds deletion-stage logs and clears protected LogEntry.api_token references prior to team deletion. |
| app/eventyay/base/models/event.py | Adds deletion-stage logs; detaches queued mail → template references before deleting mail templates; adjusts stored file deletion query. |
mariobehling
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These PR has the following changes