feat: Support self-hosted Sentry via DSN#1765
Closed
aryanjsingh wants to merge 1 commit intogetodk:masterfrom
Closed
feat: Support self-hosted Sentry via DSN#1765aryanjsingh wants to merge 1 commit intogetodk:masterfrom
aryanjsingh wants to merge 1 commit intogetodk:masterfrom
Conversation
Contributor
|
@aryanjsingh, as you closed your PR: are you no longer interested in support for self-hosted sentry? Or are you thinking about some other way to accomplish same? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change updates the Sentry configuration to use a DSN (Data Source Name) instead of separate fields for organization, key, and project. This allows users to configure Central with self-hosted Sentry instances. The Nginx configuration has been updated to parse the DSN to construct the CSP reporting endpoint, and the setup is now more robust when Sentry is not configured.
Changes
/csp-reportlocation block to use a singleSENTRY_CSP_ENDPOINTvariable. This variable will be constructed from theSENTRY_DSNin thesetup-odk.shscript, allowing for flexible Sentry endpoint configuration.return 204to gracefully handle CSP reports.dsninstead of separateorgSubdomain,key, andprojectfields. This aligns with the move to a single DSN for Sentry configuration.Related Issue
Closes #1489