Skip to content

feat(#332): Prioritize form designer's default language#763

Open
latin-panda wants to merge 8 commits intoadd-primevue-localesfrom
explicit-default-lang-and-default-input-error-translation
Open

feat(#332): Prioritize form designer's default language#763
latin-panda wants to merge 8 commits intoadd-primevue-localesfrom
explicit-default-lang-and-default-input-error-translation

Conversation

@latin-panda
Copy link
Copy Markdown
Collaborator

@latin-panda latin-panda commented Mar 31, 2026

Closes #332

I have verified this PR works in these browsers (latest versions):

  • Chrome
  • Firefox
  • Safari (macOS)
  • Safari (iOS)
  • Chrome for Android
  • Not applicable

What else has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Do we need any specific form for testing your changes? If so, please attach one.

What's changed

  • Refactors validation message in the engine
    • Removes hard-coded error message for "required" and "constraint".
    • Removes "origin" since it wasn't used, as the Vue client can evaluate the validation object to determine how to react and display the UI.
    • Validation message can be null, such as when the form designer did not specify a message.
  • Refactors default language in form
    • The form language interface has an isDefault property, which is used to mark when a form design explicitly sets one language as the default.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 31, 2026

⚠️ No Changeset found

Latest commit: 765456e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@latin-panda latin-panda marked this pull request as ready for review March 31, 2026 14:48
@latin-panda latin-panda requested a review from garethbowen March 31, 2026 16:30
@latin-panda
Copy link
Copy Markdown
Collaborator Author

@garethbowen, this is ready for review :)

Copy link
Copy Markdown
Collaborator

@garethbowen garethbowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! The engine side in particular feels so much cleaner.

I've put some minor suggestions inline.

NB: I haven't tested yet.

@latin-panda latin-panda requested a review from garethbowen April 2, 2026 18:22
@latin-panda
Copy link
Copy Markdown
Collaborator Author

@garethbowen I've wrapped up addressing the feedback and did an extra round of testing. It’s now ready for another look whenever you have a moment :)

Copy link
Copy Markdown
Collaborator

@garethbowen garethbowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thank you! I can now understand dates :)

I gave it a quick test in Firefox and Chrome but there are so many variables with browser locales it's going to be hard to find everything, but it works on my machine.

…forms into explicit-default-lang-and-default-input-error-translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants