feat(#332): Prioritize form designer's default language#763
feat(#332): Prioritize form designer's default language#763latin-panda wants to merge 8 commits intoadd-primevue-localesfrom
Conversation
…forms into explicit-default-lang-and-default-input-error-translation
|
|
@garethbowen, this is ready for review :) |
garethbowen
left a comment
There was a problem hiding this comment.
Nice work! The engine side in particular feels so much cleaner.
I've put some minor suggestions inline.
NB: I haven't tested yet.
packages/xforms-engine/src/lib/reactivity/createTranslationState.ts
Outdated
Show resolved
Hide resolved
|
@garethbowen I've wrapped up addressing the feedback and did an extra round of testing. It’s now ready for another look whenever you have a moment :) |
garethbowen
left a comment
There was a problem hiding this comment.
Fantastic! Thank you! I can now understand dates :)
I gave it a quick test in Firefox and Chrome but there are so many variables with browser locales it's going to be hard to find everything, but it works on my machine.
…forms into explicit-default-lang-and-default-input-error-translation
Closes #332
I have verified this PR works in these browsers (latest versions):
What else has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Do we need any specific form for testing your changes? If so, please attach one.
What's changed
isDefaultproperty, which is used to mark when a form design explicitly sets one language as the default.