Add buffer size setting to the Telnet component, closes #1114#1115
Open
zdimension wants to merge 3 commits intohneemann:masterfrom
Open
Add buffer size setting to the Telnet component, closes #1114#1115zdimension wants to merge 3 commits intohneemann:masterfrom
zdimension wants to merge 3 commits intohneemann:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1115 +/- ##
========================================
Coverage 56.5% 56.5%
- Complexity 6579 6580 +1
========================================
Files 680 680
Lines 35565 35571 +6
Branches 4802 4800 -2
========================================
+ Hits 20113 20122 +9
+ Misses 14242 14239 -3
Partials 1210 1210 ☔ View full report in Codecov by Sentry. |
Author
|
Is there anything I can do to facilitate the merging? @hneemann |
Author
|
anything blocking this? @hneemann |
Author
|
hallo wie gehts @hneemann |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1114