Stop merging of Wires if they are connected to a Pin#1364
Open
Nandiniae wants to merge 1 commit intohneemann:masterfrom
Open
Stop merging of Wires if they are connected to a Pin#1364Nandiniae wants to merge 1 commit intohneemann:masterfrom
Nandiniae wants to merge 1 commit intohneemann:masterfrom
Conversation
…connected to a Pin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1363
Change Constructor of WireConsistencyChecker to always need VisualElements
Changed Circuit to always include visualElements
Added TestCases for WireConsistencyCheckerTest
Modified CustomShapeDescriptionTest so there will not be a NullPointerException
Only added a WireBreak where there already was a connection with a Pin