refactor(views): Move get_record_requests to RecordCommunitiesService#3375
Open
sakshamarora1 wants to merge 1 commit into
Open
refactor(views): Move get_record_requests to RecordCommunitiesService#3375sakshamarora1 wants to merge 1 commit into
sakshamarora1 wants to merge 1 commit into
Conversation
sakshamarora1
force-pushed
the
feat/show_accepted_request
branch
from
0e97059 to
2bb29f3
Compare
carlinmack
approved these changes
Mar 20, 2026
kpsherva
reviewed
Mar 25, 2026
| return {} # secret link users do not have permissions to search requests | ||
|
|
||
| # Get all accepted requests that led to the record being added to the community | ||
| parent = record._record.parent |
Contributor
There was a problem hiding this comment.
this bypasses the service layer. Is there any way to get the parent of the record without accessing _record?
Contributor
Author
There was a problem hiding this comment.
Yeah, I thought before about moving this whole function to the service class here in rdm-records as a service method.
Because now, we are accessing the DB here as well.
Updated the PR and moved it to the service class: inveniosoftware/invenio-rdm-records#2294
sakshamarora1
force-pushed
the
feat/show_accepted_request
branch
from
2bb29f3 to
ab70290
Compare
sakshamarora1
changed the title
OliverGeneser
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: inveniosoftware/invenio-requests#568
requires: inveniosoftware/invenio-communities#1361 and inveniosoftware/invenio-rdm-records#2294