fix: not resetting errors after reservePID or file upload actions#2272
Open
Ducica wants to merge 1 commit intoinveniosoftware:masterfrom
Open
fix: not resetting errors after reservePID or file upload actions#2272Ducica wants to merge 1 commit intoinveniosoftware:masterfrom
Ducica wants to merge 1 commit intoinveniosoftware:masterfrom
Conversation
* When you upload a file or when you reserve pid, you lose all errors * previously existing in Redux, which is missleading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When you upload a file or reservePID the errors get cleared from the redux store. From UI perspective this is wrong, because it gives a wrong impression to the user. Also, logically speaking, I do not see a reason why these actions would clear existing errors from previous interactions with the server. I am not sure if there could be some obscure reason for explicitly resetting the errors in the reducer. I could not find any.
Screen.Recording.2026-03-13.at.11.10.08.mov