Skip to content

k8up-restic: pass exclude/file-from flags to restic from PVC annotations#1044

Merged
Kidswiss merged 2 commits intok8up-io:masterfrom
webconn:feature/restic-args-in-labels
Feb 26, 2025
Merged

k8up-restic: pass exclude/file-from flags to restic from PVC annotations#1044
Kidswiss merged 2 commits intok8up-io:masterfrom
webconn:feature/restic-args-in-labels

Conversation

@webconn
Copy link
Copy Markdown
Contributor

@webconn webconn commented Feb 21, 2025

Summary

This PR partially solves #317 by adding PVC annotations to pass some flags to restic in k8up wrapper, such as:

  • --exclude of all kinds
  • --files-from of all kinds
  • --one-file-system (not sure if it is actually necessary but kept it in case of complex mounts in backup job container)

It also properly splits backups between jobs if PVCs with different args annotations are involved :)

Checklist

For Code changes

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • PR contains the label area:operator
  • Commits are signed off
  • Link this PR to related issues
  • I have not made any changes in the charts/ directory.

For Helm Chart changes

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • PR contains the label area:chart
  • PR contains the chart label, e.g. chart:k8up
  • Commits are signed off
  • Variables are documented in the values.yaml using the format required by Helm-Docs.
  • Chart Version bumped if immediate release after merging is planned
  • I have run make chart-docs
  • Link this PR to related code release or other issues.

@webconn webconn requested a review from a team as a code owner February 21, 2025 15:24
@webconn webconn requested review from lieneluksika and tobru and removed request for a team February 21, 2025 15:24
Signed-off-by: Nikita Maslov <webconn@nebius.com>
@webconn webconn force-pushed the feature/restic-args-in-labels branch from 95792c3 to fac004a Compare February 21, 2025 16:34
@Kidswiss Kidswiss self-requested a review February 24, 2025 11:46
@Kidswiss Kidswiss added enhancement New feature or request area:operator labels Feb 25, 2025
@Kidswiss
Copy link
Copy Markdown
Contributor

Thanks for the contribution!

I've triggered the E2E tests, if they pass, it should be good to merge!

Signed-off-by: Nikita Maslov <webconn@nebius.com>
@webconn
Copy link
Copy Markdown
Contributor Author

webconn commented Feb 25, 2025

I've merged conflicting upstream changes, could you please run checks again? It worked OK last time

@Kidswiss Kidswiss merged commit e0621ad into k8up-io:master Feb 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:operator enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants