k8up-restic: pass exclude/file-from flags to restic from PVC annotations#1044
Merged
Kidswiss merged 2 commits intok8up-io:masterfrom Feb 26, 2025
Merged
Conversation
Signed-off-by: Nikita Maslov <webconn@nebius.com>
95792c3 to
fac004a
Compare
Contributor
|
Thanks for the contribution! I've triggered the E2E tests, if they pass, it should be good to merge! |
Signed-off-by: Nikita Maslov <webconn@nebius.com>
Contributor
Author
|
I've merged conflicting upstream changes, could you please run checks again? It worked OK last time |
Kidswiss
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR partially solves #317 by adding PVC annotations to pass some flags to restic in k8up wrapper, such as:
--excludeof all kinds--files-fromof all kinds--one-file-system(not sure if it is actually necessary but kept it in case of complex mounts in backup job container)It also properly splits backups between jobs if PVCs with different args annotations are involved :)
Checklist
For Code changes
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog
area:operatorcharts/directory.For Helm Chart changes
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog
area:chartchart:k8upmake chart-docs