Allow the case of post object to be interrupted as an array value#12
Open
mboswell-kp wants to merge 1 commit into
Open
Allow the case of post object to be interrupted as an array value#12mboswell-kp wants to merge 1 commit into
mboswell-kp wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A field of type
post_objectwith the attributemultipleset to true was yielding incorrect data results.Example JSON for fields.json
{ "label": "Foobar", "name": "foobar", "type": "post_object", "required": 0, "conditional_logic": 0, "wrapper": { "width": "", "class": "", "id": "" }, "post_type": [ "foos" ], "taxonomy": "", "allow_null": 0, "multiple": 1, "return_format": "object", "ui": 1 }With multiple posts saved in the acf field the value sent to
parse_acf_fieldwould have the following shape:A call to
get_postwith this array value always returns the first post as WordPress's native code casts it to an integer.This fix should allow the post object to be able to handle an attribute of
multiplethus serializing multiple post objects.