Skip to content

feat: disruption: make delay between disruptions configurable#2961

Open
grosser wants to merge 2 commits intokubernetes-sigs:mainfrom
zendesk:grosser/disruption-timeout
Open

feat: disruption: make delay between disruptions configurable#2961
grosser wants to merge 2 commits intokubernetes-sigs:mainfrom
zendesk:grosser/disruption-timeout

Conversation

@grosser
Copy link
Copy Markdown
Contributor

@grosser grosser commented Apr 10, 2026

Description

we had too much node churn after making consolidation faster,
here is some simple way to push back against something like that

TODO: either make it an option or add env docs, lmk what you want

How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: grosser
Once this PR has been reviewed and has the lgtm label, please assign maciekpytel for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from jmdeal and tallaxes April 10, 2026 17:28
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 10, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @grosser. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 10, 2026
@grosser grosser changed the title Grosser/disruption timeout feat: disruption: make delay between disruptions configurable Apr 10, 2026
@grosser grosser force-pushed the grosser/disruption-timeout branch from 8a28560 to a25d060 Compare April 10, 2026 17:44
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants