fix: remove unused turtle import from MCP server#538
Merged
koreyspace merged 1 commit intomicrosoft:mainfrom May 7, 2026
Merged
fix: remove unused turtle import from MCP server#538koreyspace merged 1 commit intomicrosoft:mainfrom
koreyspace merged 1 commit intomicrosoft:mainfrom
Conversation
Contributor
|
👋 Thanks for contributing @mitre88! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an accidental turtle import from the MCP server implementation to avoid unnecessary side effects and keep the module’s imports clean.
Changes:
- Removed unused
from turtle import stimport from the server module.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
12
to
14
| import re | ||
| from turtle import st | ||
|
|
||
| from typing import Optional |
There was a problem hiding this comment.
import re appears unused in this module (no re.* usage found). Since this PR is already cleaning up accidental imports, consider removing re as well and keeping the stdlib imports contiguous (no extra blank line before from typing import Optional).
koreyspace
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unused
from turtle import stimport in11-agentic-protocols/code_samples/mcp-agents/server/server.py.This import is clearly accidental (likely IDE autocomplete). The
stvariable is never used anywhere in the file, and theturtlemodule opens a graphics window on import, which would be undesirable for a server process.Testing
stis not referenced anywhere in the file