fix: clear notebook outputs containing developer paths and saved errors#539
Conversation
|
👋 Thanks for contributing @mitre88! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Pull request overview
This PR aims to sanitize teaching notebooks by clearing stored cell outputs that contain developer-specific paths and previously captured runtime errors, so learners run the notebooks fresh.
Changes:
- Cleared saved error/traceback outputs and reset
execution_counttonullin14-handoff.ipynb. - Cleared pip install output, execution results, and an initialization error output; reset
execution_counttonullin the workflow notebook. - Removed an unused import from the MCP agents server module.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| 14-microsoft-agent-framework/code-samples/14-handoff.ipynb | Clears stored error outputs and resets execution metadata for a clean teaching notebook state. |
| 11-agentic-protocols/code_samples/mcp-agents/server/server.py | Removes an unused import (non-notebook code change). |
| 08-multi-agent/code_samples/workflows-agent-framework/python/01.python-agent-framework-workflow-ghmodel-basic.ipynb | Clears stored installation/output/error cells and resets execution metadata for a clean teaching notebook state. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import asyncio | ||
| import logging | ||
| import re | ||
| from turtle import st | ||
|
|
||
| from typing import Optional |
There was a problem hiding this comment.
PR description says only notebook cell outputs were cleared and no code changes, but this file also changes Python source by removing an import. Either update the PR description / change list to include this, or split/revert this change into a separate PR if it was accidental.
Summary
Clears cell outputs from two notebooks that contained:
/Users/koreypace/ai-agents-for-beginners/.venv/...visible in pip install output cells and error tracebacksImportErrorforHandoffBuilderandServiceInitializationErrorin code cell outputsFor a teaching repository, notebooks should have clean outputs so students run them fresh.
Files Changed
14-microsoft-agent-framework/code-samples/14-handoff.ipynb08-multi-agent/code_samples/workflows-agent-framework/python/01.python-agent-framework-workflow-ghmodel-basic.ipynbTesting