Skip to content

fix: clear notebook outputs containing developer paths and saved errors#539

Merged
koreyspace merged 2 commits intomicrosoft:mainfrom
mitre88:fix/clear-notebook-outputs-pii
May 7, 2026
Merged

fix: clear notebook outputs containing developer paths and saved errors#539
koreyspace merged 2 commits intomicrosoft:mainfrom
mitre88:fix/clear-notebook-outputs-pii

Conversation

@mitre88
Copy link
Copy Markdown

@mitre88 mitre88 commented May 1, 2026

Summary

Clears cell outputs from two notebooks that contained:

  1. Hardcoded developer paths: /Users/koreypace/ai-agents-for-beginners/.venv/... visible in pip install output cells and error tracebacks
  2. Saved runtime errors: ImportError for HandoffBuilder and ServiceInitializationError in code cell outputs

For a teaching repository, notebooks should have clean outputs so students run them fresh.

Files Changed

  • 14-microsoft-agent-framework/code-samples/14-handoff.ipynb
  • 08-multi-agent/code_samples/workflows-agent-framework/python/01.python-agent-framework-workflow-ghmodel-basic.ipynb

Testing

  • Only cell outputs cleared — no code changes

Copilot AI review requested due to automatic review settings May 1, 2026 02:29
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

👋 Thanks for contributing @mitre88! We will review the pull request and get back to you soon.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to sanitize teaching notebooks by clearing stored cell outputs that contain developer-specific paths and previously captured runtime errors, so learners run the notebooks fresh.

Changes:

  • Cleared saved error/traceback outputs and reset execution_count to null in 14-handoff.ipynb.
  • Cleared pip install output, execution results, and an initialization error output; reset execution_count to null in the workflow notebook.
  • Removed an unused import from the MCP agents server module.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
14-microsoft-agent-framework/code-samples/14-handoff.ipynb Clears stored error outputs and resets execution metadata for a clean teaching notebook state.
11-agentic-protocols/code_samples/mcp-agents/server/server.py Removes an unused import (non-notebook code change).
08-multi-agent/code_samples/workflows-agent-framework/python/01.python-agent-framework-workflow-ghmodel-basic.ipynb Clears stored installation/output/error cells and resets execution metadata for a clean teaching notebook state.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 10 to 14
import asyncio
import logging
import re
from turtle import st

from typing import Optional
Copy link

Copilot AI May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description says only notebook cell outputs were cleared and no code changes, but this file also changes Python source by removing an import. Either update the PR description / change list to include this, or split/revert this change into a separate PR if it was accidental.

Copilot uses AI. Check for mistakes.
@koreyspace koreyspace merged commit 85f38c2 into microsoft:main May 7, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants