-
Notifications
You must be signed in to change notification settings - Fork 370
Replace deprecated CheckInherents with an equivalent ConsensusHook #3397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
WASM runtime size check:Compared to target branchMoonbase runtime: 2604 KB (-8 KB) ✅ Moonbeam runtime: 2756 KB (-20 KB) ✅ Moonriver runtime: 2772 KB (+4 KB) Compared to latest release (runtime-3900)Moonbase runtime: 2604 KB (+244 KB compared to latest release) Moonbeam runtime: 2756 KB (+276 KB compared to latest release) Moonriver runtime: 2772 KB (+292 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master rq/remove-deprecated-check-inherents +/- ##
========================================================================
+ Coverage 74.51% 74.57% +0.06%
- Files 392 391 -1
- Lines 95801 95769 -32
========================================================================
+ Hits 71385 71411 +26
- Misses 24416 24358 -58
|
This reverts commit 9d5a2d9.
What does it do?
Replaces deprecated
CheckInherents
with an equivalentConsensusHook
. (cumulus changes: paritytech/cumulus#2300)Discussion in Polkadot-sdk: paritytech/polkadot-sdk#2841
CheckInherents
was removed in paritytech/polkadot-sdk#9732What important points should reviewers know?