Skip to content

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Aug 18, 2025

What does it do?

Replaces deprecated CheckInherents with an equivalent ConsensusHook. (cumulus changes: paritytech/cumulus#2300)

Discussion in Polkadot-sdk: paritytech/polkadot-sdk#2841

CheckInherents was removed in paritytech/polkadot-sdk#9732

What important points should reviewers know?

@RomarQ RomarQ self-assigned this Aug 18, 2025
Copy link

coderabbitai bot commented Aug 18, 2025

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • agent-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rq/remove-deprecated-check-inherents

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@RomarQ RomarQ changed the title Rq/remove deprecated check inherents Replace deprecated CheckInherents with an equivalent ConsensusHook Aug 18, 2025
Copy link
Contributor

github-actions bot commented Aug 19, 2025

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2604 KB (-8 KB) ✅

Moonbeam runtime: 2756 KB (-20 KB) ✅

Moonriver runtime: 2772 KB (+4 KB) ⚠️

Compared to latest release (runtime-3900)

Moonbase runtime: 2604 KB (+244 KB compared to latest release) ⚠️

Moonbeam runtime: 2756 KB (+276 KB compared to latest release) ⚠️

Moonriver runtime: 2772 KB (+292 KB compared to latest release) ⚠️

Copy link
Contributor

github-actions bot commented Aug 19, 2025

Coverage Report

@@                           Coverage Diff                            @@
##           master   rq/remove-deprecated-check-inherents      +/-   ##
========================================================================
+ Coverage   74.51%                                 74.57%   +0.06%     
- Files         392                                    391       -1     
- Lines       95801                                  95769      -32     
========================================================================
+ Hits        71385                                  71411      +26     
- Misses      24416                                  24358      -58     
Files Changed Coverage
/node/service/src/lib.rs 55.49% (+0.37%) 🔼
/node/service/src/rpc.rs 85.06% (+1.73%) 🔼
/runtime/moonbase/src/lib.rs 57.20% (+1.69%) 🔼
/runtime/moonbase/tests/common/mod.rs 97.28% (-0.03%) 🔽
/runtime/moonbeam/src/lib.rs 50.51% (+1.34%) 🔼
/runtime/moonbeam/tests/common/mod.rs 94.28% (-0.05%) 🔽
/runtime/moonriver/src/lib.rs 50.42% (+1.33%) 🔼
/runtime/moonriver/tests/common/mod.rs 95.50% (-0.04%) 🔽

Coverage generated Tue Sep 23 20:24:04 UTC 2025

@RomarQ RomarQ added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes labels Sep 19, 2025
@RomarQ RomarQ added the not-breaking Does not need to be mentioned in breaking changes label Sep 22, 2025
@RomarQ RomarQ marked this pull request as ready for review September 23, 2025 18:37
@RomarQ RomarQ added the D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited label Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant