Routing without realtime data#1355
Closed
Yams709 wants to merge 3 commits intomotis-project:masterfrom
Closed
Conversation
Member
felixguendling
left a comment
There was a problem hiding this comment.
I don't see why this requires
- a new function
- variables and paramters that start with
_
We also definitely need a test case for this. Best is probably to extend the existing routing test case.
Contributor
|
I see it as a fallback function in case RT data is gibberish, especially helpful for issues with blocked trips or too early Flixbuses |
Member
This won't work with this PR unless it's a parameter you can set from outside. |
Contributor
|
The idea was to evolve this further by
|
Member
|
OJP additionally supports annotation only (routing without RT and updating the journey later). |
src/endpoints/routing.cc
Outdated
| for (auto j : r.journeys_->els_) { | ||
| j_tmp.add(std::move(j)); | ||
| } | ||
| r.journeys_ = &j_tmp; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.