Skip to content

Routing without realtime data#1355

Closed
Yams709 wants to merge 3 commits intomotis-project:masterfrom
Yams709:routing-without-rtt
Closed

Routing without realtime data#1355
Yams709 wants to merge 3 commits intomotis-project:masterfrom
Yams709:routing-without-rtt

Conversation

@Yams709
Copy link
Copy Markdown

@Yams709 Yams709 commented Mar 29, 2026

No description provided.

Copy link
Copy Markdown
Member

@felixguendling felixguendling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why this requires

  • a new function
  • variables and paramters that start with _

We also definitely need a test case for this. Best is probably to extend the existing routing test case.

@Lach-anonym
Copy link
Copy Markdown
Contributor

I see it as a fallback function in case RT data is gibberish, especially helpful for issues with blocked trips or too early Flixbuses

@felixguendling
Copy link
Copy Markdown
Member

I see it as a fallback function in case RT data is gibberish, especially helpful for issues with blocked trips or too early Flixbuses

This won't work with this PR unless it's a parameter you can set from outside.

@traines-source
Copy link
Copy Markdown
Contributor

traines-source commented Mar 30, 2026

The idea was to evolve this further by

  • supporting a hybrid mode where both realtime and non-realtime calculations are done and they are merged in one pareto_set (for that, the lambda is useful IMO) (I'm not 100% sure whether pareto_set::add or pareto_set::add_not_optimal make more sense, since we do not want duplicates, but are probably interested in non-optimal entries? Maybe we also need multiple modes for that, see below)
  • exposing this to the API via an enum e.g. rtMode=ONLY (only rt, current default), OFF (only scheduled), HYBRID (see above) and possibly later more variants

@felixguendling
Copy link
Copy Markdown
Member

OJP additionally supports annotation only (routing without RT and updating the journey later).

for (auto j : r.journeys_->els_) {
j_tmp.add(std::move(j));
}
r.journeys_ = &j_tmp;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dangling pointer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants