Skip to content

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented Sep 11, 2025

This is an explicit backport to v22.x-staging of the OpenSSL 3.5 PRs:

These all cherry-pick cleanly, but they are explicitly backported here for visibility.

Updating OpenSSL in Node.js 22.x is necessary for us to continue to support Node.js 22.x through to the planned End-of-Life date of 30 April 2027 as OpenSSL 3.0 goes out of support in September 2026.

The first commit is new and addresses concerns in #59715 by fixing the default security level to 1 to minimize disruption when updating to a newer version of Node.js 22 containing the OpenSSL 3.5 updates.

cc @nodejs/crypto @nodejs/releasers

richardlau and others added 5 commits September 11, 2025 16:35
Node.js 22 was released with OpenSSL 3.0 which had a default security
level of 1. OpenSSL 3.2 bumped this to 2, but we need to fix this at
1 to minimize disruption to users of Node.js 22.x.
PR-URL: nodejs#59234
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: nodejs#59234
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: nodejs#59371
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: nodejs#59371
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@richardlau richardlau added openssl Issues and PRs related to the OpenSSL dependency. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Sep 11, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Sep 11, 2025
@nodejs-github-bot
Copy link
Collaborator

@marco-ippolito
Copy link
Member

@richardlau can we also backport it to v20?

@nodejs-github-bot

This comment was marked as outdated.

@panva panva added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Sep 11, 2025
@nodejs-github-bot

This comment was marked as outdated.

@richardlau
Copy link
Member Author

richardlau commented Sep 11, 2025

@richardlau can we also backport it to v20?

I wasn't planning to as Node.js 20 will go End-of-Life before OpenSSL 3.0 does.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

richardlau added a commit that referenced this pull request Sep 16, 2025
Node.js 22 was released with OpenSSL 3.0 which had a default security
level of 1. OpenSSL 3.2 bumped this to 2, but we need to fix this at
1 to minimize disruption to users of Node.js 22.x.

PR-URL: #59859
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
richardlau pushed a commit that referenced this pull request Sep 16, 2025
PR-URL: #59234
Backport-PR-URL: #59859
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
richardlau pushed a commit that referenced this pull request Sep 16, 2025
PR-URL: #59234
Backport-PR-URL: #59859
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
richardlau pushed a commit that referenced this pull request Sep 16, 2025
PR-URL: #59371
Backport-PR-URL: #59859
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
richardlau pushed a commit that referenced this pull request Sep 16, 2025
PR-URL: #59371
Backport-PR-URL: #59859
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@richardlau
Copy link
Member Author

Landed in b8870c4...98e399b

@richardlau richardlau closed this Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dependencies Pull requests that update a dependency file. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants