vm: expose hasTopLevelAwait on SourceTextModule #59865
Open
+166
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose `hasTopLevelAwait` and `getHasAsyncGraph` on `vm.SourceTextModule`. `getHasAsyncGraph` requires the module to be instantiated first.
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59865 +/- ##
==========================================
+ Coverage 87.76% 88.27% +0.51%
==========================================
Files 702 702
Lines 206690 206703 +13
Branches 39679 39775 +96
==========================================
+ Hits 181392 182467 +1075
+ Misses 17252 16258 -994
+ Partials 8046 7978 -68
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Sep 13, 2025
github-actions
bot
removed
the
request-ci
joyeecheung
reviewed
Sep 14, 2025
| @@ -920,6 +920,33 @@ to disallow any changes to it. | |||
| Corresponds to the `[[RequestedModules]]` field of [Cyclic Module Record][]s in | |||
| the ECMAScript specification. | |||
|
|
|||
| ### `sourceTextModule.getHasAsyncGraph()` | |||
There was a problem hiding this comment.
Does it need to be a method? It seems fine to just make it a getter property, and it would be more consistent with other getter properties (e.g. error requires the module to be errored, but it's still a getter property)
There was a problem hiding this comment.
This requires the module to be instantiated, and throws before instantiation.
I think throwing in a getter is not a good pattern. Making it a method indicates that this could incur traversal on the dependency graph, and may throw if this is not instantiated.
joyeecheung
reviewed
Sep 14, 2025
Comment on lines
+931
to
+932
| Returns `true` if the module has a dependency graph that contains top-level | ||
| `await` expressions, otherwise returns `false`. |
There was a problem hiding this comment.
Suggested change
| Returns `true` if the module has a dependency graph that contains top-level | |
| `await` expressions, otherwise returns `false`. | |
| Iterates over the dependency graph and returns `true` if any module in its dependencies or | |
| this module itself contains top-level `await` expressions, otherwise returns `false`. | |
| The search may be slow if the graph is big enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose
hasTopLevelAwaitandgetHasAsyncGraphonvm.SourceTextModule.getHasAsyncGraphrequires the module to be instantiated first.Fixes: #59656