Skip to content

Conversation

panva
Copy link
Member

@panva panva commented Sep 12, 2025

Followup to #59841 (review)

I don't know if this is any better or not though. At least i feel it's better to not rely on require()s cache all the time?

WDYT?

@panva panva requested a review from jasnell September 12, 2025 18:38
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Sep 12, 2025
@panva
Copy link
Member Author

panva commented Sep 12, 2025

I think @aduh95 might have some good insight on this too?

@aduh95
Copy link
Contributor

aduh95 commented Sep 12, 2025

At least i feel it's better to not rely on require()s cache all the time

FWIW "cache" for internal modules would be very different than require.cache since IIUC it's populated at compile time and is not mutable. But anyway, avoiding repeated calls on require() could have positive perf impact, I guess we just have to benchmark it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants