win,tools: Add description to signature #59877
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
There was a problem hiding this comment.
Pull Request Overview
This PR adds a description parameter to the Windows code signing process to improve the user experience in UAC elevation prompts. Instead of showing a generic description, the prompt will now display "Node.js" to help users identify the software being installed or executed.
- Adds
/d "Node.js"parameter to the signtool command for Windows code signing
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jasnell
approved these changes
Sep 13, 2025
lpinca
approved these changes
Sep 13, 2025
daeyeon
approved these changes
Sep 14, 2025
When signing files for Windows, add "Node.js" as the description.
martincostello
force-pushed
the
sign-tool-description
branch
from
77cd3b9 to
2c0bf67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When signing files for Windows, add "Node.js" as the description.
This should cause the string highlighted in the UAC elevation prompt screenshot below to be replaced with the string specified as the description.