Skip to content

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Sep 14, 2025

Makes a number of updates in the quic impl

also, updates the ngtcp2 dependency and brings in the ngtcp2 example server and client to prepare to use it for building tests. DRAFT for now because I'll need to test building the examples on all the architectures.

I removed the test executables as it'll definitely require more refinement in the build to work on all the different architectures. Will move it to a separate PR

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/http2
  • @nodejs/net
  • @nodejs/security-wg

@jasnell jasnell marked this pull request as draft September 14, 2025 02:42
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Sep 14, 2025
@jasnell jasnell force-pushed the jasnell/quic-iterations branch from 5005323 to 2b9558f Compare September 14, 2025 02:51
@nodejs-github-bot
Copy link
Collaborator

@jasnell jasnell force-pushed the jasnell/quic-iterations branch from 2b9558f to fa74543 Compare September 14, 2025 03:24
@jasnell jasnell marked this pull request as ready for review September 14, 2025 03:25
@nodejs-github-bot
Copy link
Collaborator

@jasnell jasnell changed the title src: cleanup quic TransportParams class quic: multiple quic updates, update ngtcp2 dependency Sep 14, 2025
Copy link

codecov bot commented Sep 14, 2025

Codecov Report

❌ Patch coverage is 26.82927% with 90 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.49%. Comparing base (7d0f6be) to head (fa74543).
⚠️ Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
src/quic/streams.cc 0.00% 42 Missing ⚠️
src/quic/session.cc 3.12% 31 Missing ⚠️
src/quic/transportparams.cc 70.73% 10 Missing and 2 partials ⚠️
src/quic/packet.cc 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #59884      +/-   ##
==========================================
+ Coverage   88.28%   88.49%   +0.20%     
==========================================
  Files         701      702       +1     
  Lines      206790   206861      +71     
  Branches    39757    39896     +139     
==========================================
+ Hits       182569   183057     +488     
+ Misses      16243    15838     -405     
+ Partials     7978     7966      -12     
Files with missing lines Coverage Δ
src/quic/bindingdata.h 33.33% <ø> (ø)
src/quic/defs.h 67.74% <ø> (ø)
src/quic/packet.h 33.33% <ø> (ø)
src/quic/session.h 43.75% <ø> (ø)
src/quic/streams.h 0.00% <ø> (ø)
src/quic/transportparams.h 88.88% <100.00%> (ø)
src/quic/packet.cc 38.62% <28.57%> (-0.68%) ⬇️
src/quic/transportparams.cc 38.94% <70.73%> (+0.97%) ⬆️
src/quic/session.cc 29.13% <3.12%> (+0.87%) ⬆️
src/quic/streams.cc 3.20% <0.00%> (-0.14%) ⬇️

... and 89 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants