-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
quic: multiple quic updates, update ngtcp2 dependency #59884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jasnell
wants to merge
7
commits into
nodejs:main
Choose a base branch
from
jasnell:jasnell/quic-iterations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
5005323
to
2b9558f
Compare
2b9558f
to
fa74543
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59884 +/- ##
==========================================
+ Coverage 88.28% 88.49% +0.20%
==========================================
Files 701 702 +1
Lines 206790 206861 +71
Branches 39757 39896 +139
==========================================
+ Hits 182569 183057 +488
+ Misses 16243 15838 -405
+ Partials 7978 7966 -12
🚀 New features to boost your workflow:
|
Qard
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes a number of updates in the quic impl
also, updates the ngtcp2 dependency
and brings in the ngtcp2 example server and client to prepare to use it for building tests. DRAFT for now because I'll need to test building the examples on all the architectures.I removed the test executables as it'll definitely require more refinement in the build to work on all the different architectures. Will move it to a separate PR