Skip to content

Conversation

iknoom
Copy link
Contributor

@iknoom iknoom commented Sep 15, 2025

This PR replaces FIXED_ONE_BYTE_STRING(isolate, "...") literals with Environment-cached strings.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/realm
  • @nodejs/sqlite
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 15, 2025
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.29%. Comparing base (58f408f) to head (ad43278).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sqlite.cc 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #59891   +/-   ##
=======================================
  Coverage   88.29%   88.29%           
=======================================
  Files         702      702           
  Lines      206875   206871    -4     
  Branches    39797    39803    +6     
=======================================
+ Hits       182655   182662    +7     
+ Misses      16226    16208   -18     
- Partials     7994     8001    +7     
Files with missing lines Coverage Δ
src/node_realm.cc 75.14% <100.00%> (ø)
src/node_webstorage.cc 72.13% <100.00%> (-0.07%) ⬇️
src/stream_wrap.cc 87.55% <100.00%> (-0.06%) ⬇️
src/node_sqlite.cc 81.55% <50.00%> (-0.03%) ⬇️

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Flarna Flarna added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2025
@nodejs-github-bot
Copy link
Collaborator

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 16, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 17, 2025
@nodejs-github-bot nodejs-github-bot merged commit db926dc into nodejs:main Sep 17, 2025
77 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in db926dc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants