Skip to content

src: use DictionaryTemplate more in URLPattern #59892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

src: use DictionaryTemplate more in URLPattern #59892

wants to merge 1 commit into from
+72 −25

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Sep 15, 2025

Finishing updating URLPattern to use DictionaryTemplate

@jasnell jasnell requested review from addaleax and anonrig September 15, 2025 13:49
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Sep 15, 2025
@jasnell jasnell force-pushed the jasnell/urlpattern-more-dictionarytemplate branch from ce8e50a to 8fee76d Compare September 15, 2025 14:40
@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 15, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov Codecov
Copy link

codecov bot commented Sep 15, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 91.66667% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.28%. Comparing base (58f408f) to head (8fee76d).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/node_url_pattern.cc 91.66% 1 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #59892      +/-   ##
==========================================
- Coverage   88.29%   88.28%   -0.01%     
==========================================
  Files         702      702              
  Lines      206875   206905      +30     
  Branches    39797    39801       +4     
==========================================
+ Hits       182655   182661       +6     
- Misses      16226    16263      +37     
+ Partials     7994     7981      -13
Files with missing lines Coverage Δ
src/node_url_pattern.cc 84.26% <91.66%> (+0.75%) ⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69248/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@addaleax addaleax Awaiting requested review from addaleax

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasnell @nodejs-github-bot @anonrig