Skip to content

Conversation

Envoy-VC
Copy link

@Envoy-VC Envoy-VC commented Apr 7, 2025

Description

Fixes issue where .github/workflows/benchmarks.yml fails to run.

Problem

Resolves #17

Summary

Added libc++-dev install command in the Install bb Step

sudo apt install libc++-dev

Updated Compare gates reports step to use latest commit

uses: noir-lang/noir-gates-diff@dbe920a8dcc3370af4be4f702ca9cef29317bec1

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@Envoy-VC Envoy-VC changed the title Install libc++-dev during benchmarks workflow run fix: install libc++-dev during benchmarks workflow run Apr 7, 2025
@Savio-Sou Savio-Sou moved this to 👀 To Triage in Noir Libraries Apr 7, 2025
@Savio-Sou Savio-Sou moved this from 👀 To Triage to 📝 To Review in Noir Libraries Apr 7, 2025
@TomAFrench TomAFrench mentioned this pull request Apr 8, 2025
2 tasks
@TomAFrench
Copy link
Member

Thank you for flagging this issue up @Envoy-VC. I've pulled these changes into #19 where CI is passing so we're probably going to merge that PR instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while running Benchmarks Action
3 participants