Skip to content

Conversation

jialinli98
Copy link
Contributor

@jialinli98 jialinli98 commented Jul 15, 2025

Description

Problem*

Closes #18

Summary*

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jialinli98 jialinli98 requested a review from TomAFrench July 15, 2025 06:25
@jialinli98 jialinli98 changed the title chore: upgrade to sort v0.3.0 chore: upgrade to use v0.3.0 Jul 15, 2025
@jialinli98 jialinli98 changed the title chore: upgrade to use v0.3.0 chore: upgrade to use sort v0.3.0 Jul 15, 2025
@TomAFrench TomAFrench changed the title chore: upgrade to use sort v0.3.0 feat: upgrade to use sort v0.3.0 Jul 15, 2025
@TomAFrench TomAFrench changed the title feat: upgrade to use sort v0.3.0 chore!: upgrade to use sort v0.3.0 Jul 15, 2025
@TomAFrench
Copy link
Member

This PR is introducing the same issue that the zkpassport team did on their sha1 library here. We want to avoid truncating Field types into u32 when it's more appropriate to range constrain them.

It looks like self.keys and self.linked_keys should be using u32 types rather than Field internally.

@jialinli98 jialinli98 closed this Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade dependency sort to v0.3.0
2 participants