Conversation
📝 WalkthroughWalkthroughDataized's exception-enclosure matching was changed: jump-token detection now uses suffix matching and string-type enclosure matching was updated to a fully-qualified form. Two tests in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Performance AnalysisAll benchmarks are within the acceptable range. No critical degradation detected (threshold is 100%). Please refer to the detailed report for more information. Click to see the detailed report
✅ Performance gain: |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
eo-runtime/src/test/java/org/eolang/DataizedTest.java (1)
84-84: Remove leftover commented annotation.Line 84 (
//@Disabled) should be deleted now that the test is intentionally enabled; keeping commented test-control annotations makes intent less clear.✂️ Suggested cleanup
- //@Disabled🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@eo-runtime/src/test/java/org/eolang/DataizedTest.java` at line 84, Delete the leftover commented test-control annotation `//@Disabled` in the DataizedTest class (remove the commented line containing `@Disabled`) so the test is clearly enabled; locate it in org.eolang.DataizedTest (class DataizedTest) and remove that single commented annotation line to avoid confusion.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@eo-runtime/src/test/java/org/eolang/DataizedTest.java`:
- Line 84: Delete the leftover commented test-control annotation `//@Disabled`
in the DataizedTest class (remove the commented line containing `@Disabled`) so
the test is clearly enabled; locate it in org.eolang.DataizedTest (class
DataizedTest) and remove that single commented annotation line to avoid
confusion.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9146f181-e6b9-492d-a2a4-9629ef8bb584
📒 Files selected for processing (2)
eo-runtime/src/main/java/org/eolang/Dataized.javaeo-runtime/src/test/java/org/eolang/DataizedTest.java
|
@yegor256, please take a look at this pull request. The fourth test: fails due to:
As I understand, this failure would occur for any PR, not just this one. Could there be a problem in the CI/CD pipeline? |
Update Dataized to handle new EO package naming format
What does this PR do?
Fixes the
logsAllLocationsWithPhSafeanddoesNotLogGoToTokenJumptests, which were disabled after migrating EO objects from theorg.eolangpackage toQ. FixesDataizedmethods to work correctly with the new name format.Related issues:
QQPrefix Causes Redundancy in Package Naming #4538Changes
Dataized.javaforma()condition for error messages from%s.stringto%s.org.eolang.stringenc.forma().endsWith("go.to.token.jump")check to properly handlego.to.token.jump(works with both formats:org.eolang.go.to.token.jumpandΦ.go.to.token.jump)System.out.printlnstatementsDataizedTest.java@DisabledfromlogsAllLocationsWithPhSafetest@DisabledfromdoesNotLogGoToTokenJumptest@todolines (38-41)org.junit.jupiter.api.DisabledHow to test
Notes
org.eolangpackage toQ, which changed theforma()return formatendsWith()Summary by CodeRabbit
Summary by CodeRabbit
Bug Fixes
Tests