Fix(#4538) Update Dataized for Q/Φ package format migration#4978
Fix(#4538) Update Dataized for Q/Φ package format migration#4978AlexNetTie wants to merge 8 commits intoobjectionary:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughDataized.take() now matches enclosure forms using suffix checks ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Performance AnalysisAll benchmarks are within the acceptable range. No critical degradation detected (threshold is 100%). Please refer to the detailed report for more information. Click to see the detailed report
✅ Performance gain: |
| throw new EOerror.ExError(enc); | ||
| } | ||
| if (String.format("%s.string", PhPackage.GLOBAL).equals(enc.forma())) { | ||
| if (enc.forma().endsWith(".string")) { |
There was a problem hiding this comment.
@AlexNetTie it's a hack and does not solve the real problem with incorrect forma of the object
@yegor256 FYI
There was a problem hiding this comment.
@maxonfjvipon, Thank you, I will continue to correct it.
|



Update Dataized to handle new EO package naming format
What does this PR do?
Fixes the logsAllLocationsWithPhSafe and doesNotLogGoToTokenJump tests, which were disabled after migrating EO objects from the org.eolang package to Q. Fixes Dataized methods to work correctly with the new name format.
Related issues:
Changes
Dataized.java
DataizedTest.java
How to test
Notes
The issue occurred after migrating objects from org.eolang package to Q, which changed the forma() return format
Fixes are backward compatible and work with the old format via endsWith()
All tests pass, qulice shows no errors
Summary by CodeRabbit
Bug Fixes
Tests