Conversation
|
I am no familiar with creating windows installers, but my only concern is the license of installer logo. From where did you get it? |
It's a placeholder and from Chrome's installer, but obviously they took it from windows. Removed and let's see if we can get a new logo to use. |
c227412 to
f7a8388
Compare
There was a problem hiding this comment.
Pull request overview
Adds Windows installer generation (NSIS via CPack), including automatic download/bundling of required third-party installers and CI wiring for packaging.
Changes:
- Add Windows CPack/NSIS packaging configuration and componentized install rules.
- Add NSIS script/template and helper macros for dependency install, env-var setup, and uninstall behaviors.
- Update PowerShell build script and Windows CI workflow to install NSIS and run packaging targets.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/build_dlstreamer_dlls.ps1 | Installs NSIS + plugins, switches build dir to repo, and adds packaging steps/flags. |
| LICENSE | Updates copyright year range to 2018–2026. |
| CMakeLists.txt | Includes Windows packaging configuration on WIN32 builds. |
| cmake/packaging/windows/NSIS.template.in | Custom CPack NSIS template enabling extra hooks/defines for DL Streamer installer. |
| cmake/packaging/windows/install_targets.cmake | Defines component install rules and custom target to download installer dependencies. |
| cmake/packaging/windows/download_deps.cmake | Adds CMake script to download/verify GStreamer & Python installers. |
| cmake/packaging/windows/dlstreamer.nsh | Implements installer logic (dependency checks, env vars, cleanup, hash verification, uninstall UI). |
| cmake/packaging/windows/cpack_windows.cmake | Configures CPack NSIS generator, versions/hashes, signing hooks, and packaging targets. |
| .github/workflows/dls-build-and-test-windows.yaml | Updates build output directory and sets NSIS_SKIP_COMPRESSION for CI builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
03ab8a7 to
4d75c75
Compare
|
I see the first step of the installer is compiling the source code. |
The build_dlstreamer_dlls.ps1 is not the installer. It generates an exe installer which will be released on GitHub. There will be no more DLL-only releases in the future. |
Description
Requires GStreamer 1.28.2+.
Builds an offline installer with all dependencies bundled.
Fixes # (issue)
Any Newly Introduced Dependencies
NSIS: zlib/libpng license (https://nsis.sourceforge.io/License)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: